Fix mentor deadminning and admin loading #10426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If an admin had mentor status beforehand, would this still keep the mentor-only verbs? |
|
Nope. Fixing that now. |
PowerfulBacon
approved these changes
Feb 15, 2024
ss13-beebot
added a commit
that referenced
this pull request
Feb 15, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
* Fix mentor deadminning and admin loading * Fix admin-mentors not keeping their verbs after deadminning
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
JixS4v
added a commit
to JixS4v/BeeStation-Hornet
that referenced
this pull request
Jul 10, 2024
This reverts commit fc314a5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Previously the mentor system would just regenerate all mentor datums whenever an admin changed their status. This was really wasteful because the database never actually changes when an admin does this, it's just trying to delete the datum.
Instead of deleting and regenerating the datums, I just keep them associated now and remove the verbs + hrefs from deadminned admins.
Also added some early returns to admin procs.
Why It's Good For The Game
Less time wasted reloading mentors, admins no longer have mentor-only verbs that don't work.
Testing Photographs and Procedure
Screenshots&Videos
Before
After
No wasted load_mentors:
Changelog
🆑
fix: Mentors are no longer reloaded when admin datums are created.
tweak: Admins can no longer see mentor-only verbs when deadminned.
/:cl: