Speed up ByondUI mounting #10427
Merged
Speed up ByondUI mounting #10427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
TGUI-Changes
PowerfulBacon
approved these changes
Jan 8, 2024
RimiNosha
added a commit
to Artea-Station/Artea-Station-Server
that referenced
this pull request
Jan 10, 2024
## About The Pull Request BeeStation/BeeStation-Hornet#10427 Holy shit itsmeow, you goddamn legend. This has been a consistent pain in my ass since I did the prefs refactor. ## How Does This Help ***Gameplay***? Opening certain UIs in prefs no longer fucking murders your game. ## Proof of Testing See the beestation PR, it works. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: code: Character previews should lag the client significantly less. /:cl: <!-- Both :cl:s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
ZeWaka
added a commit
to goonstation/goonstation
that referenced
this pull request
Jan 16, 2024
mega ByondUI mounting speedup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This greatly speeds up the remounting process of ByondUIs, making the process of switching tabs in the preference menu much snappier on the clientside. It won't open any faster, but just switching off of loadouts and the character editor should feel much better.
The way this works is rather than removing the element from the skin by changing the parent, it just sets it non-visible. This process is apparently much faster within BYOND's skin code, so it renders much faster.
Why It's Good For The Game
Less client lag when using the preference menu.
Testing Photographs and Procedure
Screenshots&Videos
Before
2024-01-06.04-39-51.mp4
After
2024-01-06.04-36-43.mp4
Changelog
🆑
code: Optimized ByondUI rendering, making the preferences preview remount much faster when changing tabs in the preference menu. This should be most apparent when switching from the Character or Loadout tab to another.
/:cl: