Optimize PDA painter init, improve init tracking #10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ss13-beebot
added a commit
that referenced
this pull request
Feb 17, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Optimized PDA painter init (re-implementing part of the reverted #9481). The
colorlistdoes literally nothing, it's not used anywhere. lol.Saves around 65ms and removes dead code.
Improves the atom init tracking by making columns no longer aggregate sums. This allows further data to be extrapolated such as mean-time-per-init and init counts. Adds a little warning since the profiles are now ~20mb
Why It's Good For The Game
Improve init times.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
code: Optimized PDA painter init, saving 65ms.
/:cl: