Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes plasma being worth 100x its value when in a stack of 2 or greater #10443

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Jan 8, 2024

About The Pull Request

It wasnt an extra zero, it was some weird shitcode due to 'k_elasticity' or whatever that is.

A single stack of plasma would read the expected value, but it logarithmic-ally increased until it reached 50.

Also, removes superscripting from mat exports, because I added them, and they didnt work. So now I am unadding them.

Why It's Good For The Game

50 stacks of plasma are now worth 5,999, not 500,000.

Testing Photographs and Procedure

Stack of 50 plasma before & after fix

Prior to fix

image

After the fix

image

Changelog

🆑 rkz, dakae
fix: Plasma no longer has broken material amounts due to /datum/export fuckery
fix: fixed broken material export formatting
/:cl:

@Tsar-Salat
Copy link
Contributor Author

Im shamelessly adding #10397 into this pr because its a fix & it will get merged faster.

@PowerfulBacon
Copy link
Member

What does this PR actually do? There are no code changes in it?

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see it now

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jan 8, 2024
Merged via the queue into BeeStation:master with commit 8ae2bc9 Jan 8, 2024
8 checks passed
@Tsar-Salat Tsar-Salat deleted the fix-mat-prices branch January 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants