WORKING Directional Lighting in 2024

[Tsar-Salat]

Ports:

• [READY]Directional lighting component + light system tgstation/tgstation#54520
• Fixes gunlight runtime related to overlay lighting tgstation/tgstation#54614
• Makes overlay lighting flags actually respond to attaching/detaching lights tgstation/tgstation#57058
• Fixes losing dynamic luminosity on ChangeTurf() tgstation/tgstation#60218
• Fixes an underlay movable lighting runtime tgstation/tgstation#60336
• fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons tgstation/tgstation#60756
• Fixes lighting overlays from an item sometimes showing up on inventory slots / backpack slots instead of from the mob holding them. tgstation/tgstation#70250
• Fixes directional light overlay leaking the lighting mask and not updating direction correctly tgstation/tgstation#70578
• Lighting object oddities tgstation/tgstation#76009

About The Pull Request

This ports the directional lighting system from Teegee. Its a recoup of #7418, and #8093

Essentially, this adds a cone in front of the lightsource, rather than a radius of light. This is meant to emulate lights like headlights or flashlights.

Radius-based light sources & directional light sources are defined by its MOVABLE_LIGHT define

TODO

• fix ethereals mutcolors getting reset to white
• fix weird light toggling bug

Why It's Good For The Game

This is a direct upgrade of our lighting system.

As we tend towards projects like #10473, I think this is a good complement to what it is trying to achieve, which is why I am reviving this PR

Testing Photographs and Procedure

Screenshots&Videos

dreamseeker_ZkNp5kL7RA.mp4

Working Gunlights

dreamseeker_f6TSk2wbMx.mp4

Working Ethereals

Changelog

🆑 rkz, azarak, TemporalOroboros, Rohesie, Couls, ShizCalev, TastyFish
add: Adds directional lighting system in 2024!
add: adds directional lighting to cyborg lights, flashlights, and gunlights
refactor: refactors glow effects to be less terrible. Includes ethereal glow, and also the glowy/antiglowy mutation.
/:cl:

[MarkusLarsson421]

Correct me if I am wrong, but it looks like it is just off-setting the light source a few meters in front of where you are facing?

[Tsar-Salat]

oops lol

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Rukofamicom]

What's up with mineral scan pulse?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Rukofamicom]

damn conflicts can't make up their mind and neither can I because of them

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Rukofamicom]

In the event this doesn't merge cleanly, ping for re-attempt please.
This is very prone to conflicts so we should get it in as soon as we can.

I may be busy at the moment and unable to respond, but I can push the merge button even remotely if it's not currently conflicted