Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical factories: Medical usage edition #10750

Merged
merged 11 commits into from
Aug 4, 2024

Conversation

PowerfulBacon
Copy link
Member

@PowerfulBacon PowerfulBacon commented Mar 15, 2024

About The Pull Request

  • Removes the pill press
  • Removes the patch dispensor
  • Bottle dispensor renamed to bottle filler and will now only fill open containers on interact
  • Chemical synthesisers now use power
  • Chemical synthesisers no longer require matter

Why It's Good For The Game

Chemical factories were essentially soft-removed by the requirement for a huge amount of matter to be effective. After some recent discussion in general, and consolidating on some of my own experiences playing chemist, the main thing I dislike about chemistry is having to produce large amounts of a certain reagent as it is often time consuming and not fun. Chemical factories are perfect for producing chemicals which need to be created on-masse throughout a round, so why not encourage them to be used for that purpose.

I specifically remove the pill press, bottle dispensor and patch dispensor since I don't want people making factories that just pump out self-healing medicine in-front of medbay. I want these to be used by doctors, or chemists to pass on to other people, to refill medbots, or to keep sleepers full.

Testing Photographs and Procedure

image

image

Changelog

🆑
balance: Chemical factories now use power instead of matter.
del: Removes pill presses and patch dispensors.
tweak: Bottle dispensors no longer produce glass bottles out of nowhere, they now require a bottle to fill.
fix: The plumbing RCD can now print bottle fillers.
/:cl:

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Mar 15, 2024
@PowerfulBacon PowerfulBacon marked this pull request as ready for review March 15, 2024 09:42
@github-actions github-actions bot added the Mapping DMM Change label Mar 15, 2024
@MarkusLarsson421
Copy link
Contributor

While this is done, could the player collision of the pipes be removed so they can be walked over?

@PowerfulBacon
Copy link
Member Author

They can be walked over, I put the pipes first and then set the synthesisers afterwards

@MarkusLarsson421
Copy link
Contributor

They can be walked over, I put the pipes first and then set the synthesisers afterwards

Has this always been the case? Could've sworn you couldn't.

@EvilDragonfiend
Copy link
Member

What's this different from Output gate?

@PowerfulBacon
Copy link
Member Author

PowerfulBacon commented Mar 15, 2024

Presentation. And also I don't know if output gates can dispense into containers, only syringes

@Rukofamicom
Copy link
Contributor

Would you consider adding a way to link medbots directly to the filler?

Presentation. And also I don't know if output gates can dispense into containers, only syringes

They can dispense into containers.

@PowerfulBacon
Copy link
Member Author

I want to add medbot stations which can be filled with chemicals and have medbots automatically go there when they deplete, but the amount of work is significantly greater to do that than the simple changes in this PR

@EvilDragonfiend EvilDragonfiend added Don't review yet Reviewing this at this stage would be a waste of time. DO NOT MERGE On hold and removed DO NOT MERGE labels Mar 16, 2024
@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Mar 16, 2024

In favour of temporary(?) revert of bioscanner, it should be on hold.

Also, this PR will conflict with

@PowerfulBacon PowerfulBacon removed the Don't review yet Reviewing this at this stage would be a waste of time. label Mar 16, 2024
@PowerfulBacon
Copy link
Member Author

It shouldn't conflict, the other PR is simply moving the plumbing stuff to its own locker rather than changing anything about it. This can work alongside the bioscanner and comes about as a result of feedback on the medbot changes, rather than the bioscanner; however not merge conflicting the bioscanner revert is critical

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Liver-1
Copy link
Contributor

Liver-1 commented Apr 30, 2024

The evil has been defeated

@PowerfulBacon PowerfulBacon requested a review from a team as a code owner May 9, 2024 11:15
@PowerfulBacon
Copy link
Member Author

Despite git claiming that there are no changes from master to my branch, there are a ton of changes to the map. No clue why the diffs are so large.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nanimies
Copy link

please it's been three months when this first got opened, i just want my meth factory back

Copy link
Contributor

@PestoVerde322 PestoVerde322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good on the mapfront, but, is it really necessary to keep a void as a stark reminder of what it had? place a good ol' fulltile window!

@MarkusLarsson421
Copy link
Contributor

I'd say remove all those things should be removed to allow the chemist to put in whatever they want.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon merged commit 56006ca into BeeStation:master Aug 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance/Rebalance Fix Mapping DMM Change Removal TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants