-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryogenic freezer no longer accepts mobs that were never controlled by a player #10833
Conversation
dont DC'd players no longer have a key attached to them? or ghosted ones? if that is the case this would make you unable to cryo them too, no? |
Oh ffs, true, I did aghost, not ghost while I was testing this, smh |
Check for no mind instead, since disconnected players that were once controlled by a player will still have a mind |
it should be mind based |
Bacon's point is preventing non-humans being cryo when they have no key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine
This will allow for Xenobio mobs/morphs/etc to cryo then? |
If they have a mind yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last mind isn't necessary. Last mind without mind means it's a dead body, or a brain-swapped body, like a monkey brain having your original body, or vice versa.
so, if(!iscarbon(target) && !target.mind)
will be enough
I'll only check for mind, I think we should be able to cryo mobs (not only carbons) with a player inside them |
Would allow people throwing in monkey cubes humans without a mind, we'd be having the same issue if someone decided to fill the Cryo Chambers |
Honestly, yeah, cryoing mindless isn't a thing. It's enough. |
…y a player (BeeStation#10833) * NO more evil cryo * typo * Now we do it properly and test it * Remove bloat code * Typo
About The Pull Request
fixes #10824
Now you can't put a mob without a key inside a cryo-chamber
Why It's Good For The Game
Stop players from getting the Cryo-chambers full of mobs...
Testing Photographs and Procedure
Screenshots&Videos
2024-04-04.12-11-34.mp4
Changelog
🆑 Miliviu
tweak: cryogenic freezer no longer accepts mobs that were never controlled by a player
/:cl: