Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryogenic freezer no longer accepts mobs that were never controlled by a player #10833

Merged
merged 5 commits into from
Apr 6, 2024

Conversation

Miliviu
Copy link
Contributor

@Miliviu Miliviu commented Apr 4, 2024

About The Pull Request

fixes #10824

Now you can't put a mob without a key inside a cryo-chamber

Why It's Good For The Game

Stop players from getting the Cryo-chambers full of mobs...

Testing Photographs and Procedure

Screenshots&Videos
2024-04-04.12-11-34.mp4

Changelog

🆑 Miliviu
tweak: cryogenic freezer no longer accepts mobs that were never controlled by a player
/:cl:

@Marshmellow105
Copy link
Contributor

dont DC'd players no longer have a key attached to them? or ghosted ones? if that is the case this would make you unable to cryo them too, no?

@Miliviu Miliviu changed the title NO more evil cryo Cryogenic Freezer no longer accepts mobs without ckey Apr 4, 2024
@Miliviu
Copy link
Contributor Author

Miliviu commented Apr 4, 2024

dont DC'd players no longer have a key attached to them? or ghosted ones? if that is the case this would make you unable to cryo them too, no?

Oh ffs, true, I did aghost, not ghost while I was testing this, smh

@Miliviu Miliviu marked this pull request as draft April 4, 2024 09:55
@PowerfulBacon
Copy link
Member

Check for no mind instead, since disconnected players that were once controlled by a player will still have a mind

@EvilDragonfiend
Copy link
Member

it should be mind based

@Miliviu
Copy link
Contributor Author

Miliviu commented Apr 4, 2024

Check for no mind instead, since disconnected players that were once controlled by a player will still have a mind

Not really, if you ghost the mind gets removed, if is a carbon you have last_mind tho
image

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Apr 4, 2024

Bacon's point is preventing non-humans being cryo when they have no key.
But honestly, it should be just mind based because we sometimes want cryo someone

@Miliviu Miliviu changed the title Cryogenic Freezer no longer accepts mobs without ckey Cryogenic freezer no longer accepts mobs that were never controlled by a player Apr 4, 2024
@Miliviu Miliviu marked this pull request as ready for review April 4, 2024 10:14
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine

@Fronsis
Copy link

Fronsis commented Apr 4, 2024

Bacon's point is preventing non-humans being cryo when they have no key. But honestly, it should be just mind based because we sometimes want cryo someone

This will allow for Xenobio mobs/morphs/etc to cryo then?

@Miliviu
Copy link
Contributor Author

Miliviu commented Apr 4, 2024

Bacon's point is preventing non-humans being cryo when they have no key. But honestly, it should be just mind based because we sometimes want cryo someone

This will allow for Xenobio mobs/morphs/etc to cryo then?

If they have a mind yeah

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last mind isn't necessary. Last mind without mind means it's a dead body, or a brain-swapped body, like a monkey brain having your original body, or vice versa.
so, if(!iscarbon(target) && !target.mind) will be enough

@Miliviu
Copy link
Contributor Author

Miliviu commented Apr 5, 2024

I'll only check for mind, I think we should be able to cryo mobs (not only carbons) with a player inside them

@Miliviu
Copy link
Contributor Author

Miliviu commented Apr 5, 2024

if(!iscarbon(target) && !target.mind)

Would allow people throwing in monkey cubes humans without a mind, we'd be having the same issue if someone decided to fill the Cryo Chambers

@Miliviu Miliviu requested a review from EvilDragonfiend April 5, 2024 07:27
@EvilDragonfiend
Copy link
Member

Honestly, yeah, cryoing mindless isn't a thing. It's enough.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Apr 6, 2024
Merged via the queue into BeeStation:master with commit 8f10bd6 Apr 6, 2024
8 checks passed
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
…y a player (BeeStation#10833)

* NO more evil cryo

* typo

* Now we do it properly and test it

* Remove bloat code

* Typo
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] You can drag non-human NPCs into cryo-storage.
5 participants