-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghost orbiting a zmimic will make you orbit the original atom. #10856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
approved these changes
Apr 8, 2024
PowerfulBacon
requested changes
Apr 8, 2024
itsmeow
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer if instead of being get_orbitable, it actually handled the initiation of the orbit instead so that you can do special things with it (observer.orbit(src)
as default behaviour) but this works fine enough for me.
Co-authored-by: PowerfulBacon <[email protected]>
Co-authored-by: PowerfulBacon <[email protected]>
PowerfulBacon
approved these changes
Apr 10, 2024
ss13-beebot
added a commit
that referenced
this pull request
Apr 11, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
…ation#10856) * It just works * fucky wucky * Refactor * Update code/game/atoms.dm Co-authored-by: PowerfulBacon <[email protected]> * Update code/modules/multiz/zmimic/mimic_movable.dm Co-authored-by: PowerfulBacon <[email protected]> --------- Co-authored-by: PowerfulBacon <[email protected]>
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What it says on the tin.
Closes #10731
Why It's Good For The Game
Bug bad
Testing Photographs and Procedure
Screenshots&Videos
yep.mp4
Changelog
🆑
fix: orbiting a zmimic as a ghost will make you orbit the original atom.
/:cl: