Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost orbiting a zmimic will make you orbit the original atom. #10856

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

JixS4v
Copy link
Contributor

@JixS4v JixS4v commented Apr 5, 2024

About The Pull Request

What it says on the tin.
Closes #10731

Why It's Good For The Game

Bug bad

Testing Photographs and Procedure

Screenshots&Videos
yep.mp4

Changelog

🆑
fix: orbiting a zmimic as a ghost will make you orbit the original atom.
/:cl:

code/_onclick/observer.dm Outdated Show resolved Hide resolved
@JixS4v JixS4v requested a review from itsmeow as a code owner April 9, 2024 18:34
@JixS4v JixS4v requested a review from PowerfulBacon April 9, 2024 18:38
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer if instead of being get_orbitable, it actually handled the initiation of the orbit instead so that you can do special things with it (observer.orbit(src) as default behaviour) but this works fine enough for me.

code/game/atoms.dm Outdated Show resolved Hide resolved
code/modules/multiz/zmimic/mimic_movable.dm Outdated Show resolved Hide resolved
JixS4v and others added 2 commits April 9, 2024 22:45
@JixS4v JixS4v requested a review from PowerfulBacon April 9, 2024 21:05
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Apr 11, 2024
Merged via the queue into BeeStation:master with commit 145f437 Apr 11, 2024
8 checks passed
@JixS4v JixS4v deleted the mimic-orbit branch April 11, 2024 20:46
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
…ation#10856)

* It just works

* fucky wucky

* Refactor

* Update code/game/atoms.dm

Co-authored-by: PowerfulBacon <[email protected]>

* Update code/modules/multiz/zmimic/mimic_movable.dm

Co-authored-by: PowerfulBacon <[email protected]>

---------

Co-authored-by: PowerfulBacon <[email protected]>
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost Orbiting on zmimic should orbit its original atom
3 participants