[MDB Ignore]Fix every missing icon. Add icons for every worn item. #10869
Conversation
| @@ -220,9 +220,6 @@ GLOBAL_LIST_INIT(meteorsC, list(/obj/effect/meteor/dust)) //for space dust event | |||
| meteor_effect() | |||
| qdel(src) | |||
|
|
|||
| /obj/effect/meteor/ex_act() | |||
There was a problem hiding this comment.
Instead of 10 snowflake ex_act handlings for every child of /effect/, we simply do it all on effect.
Incredible.
| @@ -476,7 +476,7 @@ | |||
| /obj/item/bodypart/chest | |||
| name = BODY_ZONE_CHEST | |||
| desc = "It's impolite to stare at a person's chest." | |||
| icon_state = "default_human_chest" | |||
| //icon_state = "default_human_chest" | |||
There was a problem hiding this comment.
I preserve this in a comment because its a really bad way to have it. This NEEDS to be fixed in a proper kapulimbs port.
However bodyparts default to their main dmi file, greyscaled parts, which isnt what these icon_states are trying to point at, nor can I just put the proper icons in the greyscale folder (it would fuck it up).
Fun stuff, really.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| body_parts_covered = CHEST|GROIN|LEGS|FEET | ||
| flags_inv = HIDEJUMPSUIT|HIDESHOES | ||
|
|
||
| /obj/item/clothing/suit/hooded/carp_costume |
There was a problem hiding this comment.
1st "hardsuit" converted into a hooded suit and given spaceproof. This is because under this pr, typepaths direct towards specific .dmi now
| body_parts_covered = CHEST|GROIN|LEGS|ARMS | ||
| allowed = list(/obj/item/tome, /obj/item/melee/cultblade) | ||
| armor = list(MELEE = 50, BULLET = 30, LASER = 50, ENERGY = 20, BOMB = 25, BIO = 10, RAD = 0, FIRE = 10, ACID = 10, STAMINA = 50) | ||
| flags_inv = HIDEGLOVES|HIDESHOES|HIDEJUMPSUIT | ||
|
|
||
| /obj/item/clothing/head/helmet/space/hardsuit/cult | ||
| /obj/item/clothing/suit/hooded/cultrobes/hardened |
There was a problem hiding this comment.
2nd "hardsuit" converted into a hooded suit and given spaceproof. This is because under this pr, typepaths direct towards specific .dmi now.
Also made no sense being a hardsuit
|
testing evidence added , no more unit test errors, see no issues on energy guns. We're ready to roll 😎 |
| @@ -62,6 +63,7 @@ | |||
| name = "doctor's bag" | |||
| icon_state = "firstaid-surgeryalt" | |||
| item_state = "firstaid-surgeryalt" | |||
| worn_icon_state = "baguette" | |||
There was a problem hiding this comment.
You turned my bag into a baguette.
I'll pay you double of what the French paid you to release my bag from the carbohydrate-prison.
(belt slot)
There was a problem hiding this comment.
@lowwy I didn't turn it into anything, rather doctors bags are supposed to have a worn state, but do not.
I chose to use baguettes for several of these cases as they both have a valid back and waist sprite.
Whoever made doctors use "Doctor's Bags" at roundstart neglected their due diligence, it needs an actual worn sprite like the medkit doctors used before.
There was a problem hiding this comment.
Yeah no worries, just some banter, I though it would be something like that. just making sure!
BeeStation#10869 broke the alt jumpsuit by renaming the base state and not changing anything else. This updates both the alt name and the sprite itself
#10869 broke the alt jumpsuit by renaming the base state and not changing anything else. This updates both the alt name and the sprite itself
About The Pull Request
Ports:
suit/toggleto component behavior tgstation/tgstation#61941 (component unused. Simply detaching hardcoded typepath behavior)closes #10956
Fix all missing icons
Adds a unit test to yell at you if you input an improper icon_state entry.
Yes, now I have to resolve every missing icon in the game.
If you want to see my progress, just look
Sorting clothing folders
I am sorting the clothing folders based on category/department
Why It's Good For The Game
Yes. Missing Icons bad. We hold the little coders responsible for when they LEAVE OUT their icons in their PRs!!!!
Looking at YOU @kit-katz #8458 and YOU @MarkusLarsson421 #10548
Testing Photographs and Procedure
Screenshots&Videos
You know its working when the unit test stops yelling at me.
E-guns
dreamseeker_G34cM6keco.mp4
Clothing icon & spritesheet test
GfamDg1YlN.mp4
Changelog
🆑 rkz(organized & repathed every clothing sprite), MrMelbert, ShizCalev, ArcaneMusic(code contribution), maxymax13, TaG2e, LordVollkorn, Twaticus(sprite contribution)
add: A hell of a lot of new belt/back sprites for items
tweak: Lawyer's aristocratic coats are now under premium in vendor
fix: All missing sprite icon_states in the game are now accounted for.
fix: All missing sprite worn_states in the game are now accounted for.
code: all offending coders have been taken out back and cried at
code: Implements full missing icon unit test
code: Organizes obj/clothing & mob/clothing by category & typepath
code: hooded cult robes now use hooded typepath instead of being hardsuit subtypes (all stats preserved)
code: hooded carp suit now use hooded typepath instead of being hardsuit subtypes (all stats preserved)
code: adjusts several body_parts_covered flags on different clothes articles to fix worn_icon issues
/:cl: