Fixes wrong signal usages #10875
Merged
Fixes wrong signal usages #10875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
commented
Apr 10, 2024
Comment on lines
21
to
22
| RegisterSignalsDynamic(parent, change_on, PROC_REF(handle_change)) | ||
| RegisterSignalsDynamic(parent, remove_on, PROC_REF(handle_removal)) |
There was a problem hiding this comment.
If you wonder how TG managed that, here you are:
// change on can be a list of signals
if(islist(change_on))
RegisterSignals(parent, change_on, PROC_REF(handle_change))
else if(!isnull(change_on))
RegisterSignal(parent, change_on, PROC_REF(handle_change))
// remove on can be a list of signals
if(islist(remove_on))
RegisterSignals(parent, remove_on, PROC_REF(handle_removal))
else if(!isnull(remove_on))
RegisterSignal(parent, remove_on, PROC_REF(handle_removal))
There was a problem hiding this comment.
I would rather cover this edge case than add a DEFINE that's used twice and will be quickly forgotten about.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
EvilDragonfiend
force-pushed
the
signalfixes
branch
from
d35cbe0 to
fdbca0a
Compare
PowerfulBacon
approved these changes
Apr 24, 2024
ss13-beebot
added a commit
that referenced
this pull request
Apr 24, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
* Signal fixes * Removes dynamic macro * I didn't save this.. Removes dynamic macro. * Update COMPONENT_TEMPLATE.md * nitpick * nitpick 2
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes wrong signal usages
Regex search to find issues
RegisterSignals\([a-zA-Z_]+, COMSIG: searches for signals with wrong usage - RegisterSignals should take listChanges into
RegisterSignalRegisterSignals\([a-zA-Z_]+, list\(COMSIG[a-zA-Z_]+\): searches for a signal with a single listChanges into
RegisterSignalRegisterSignal\([a-zA-Z_]+, list: searches for signals with wrong usage - It can be a list orChanges into
RegisterSignalsRegisterSignal([s]?)\([a-zA-Z_]+, [a-z_]+: searches for signals that might have been taken variableChanges into
RegisterSignalsRegisterSignal([s]?)\([a-zA-Z,/\s_]+\/proc: searches for non-macro procs for signalsChanges into
TYPE_PROC_REF()Why It's Good For The Game
Bug fix, runtime fix, etc
Testing Photographs and Procedure
This isn't what I can't test fully
Changelog
🆑
code: fixed wrong usage of signal procs
/:cl: