Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS to use a mapping team for maps #10879

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

PowerfulBacon
Copy link
Member

About The Pull Request

Updates code-owners so that it works by using a team instead of an individual person.

Why It's Good For The Game

More flexability and the use of teams allows for setting up specific rules per-group (mappers can only merge mapping changes, as an example).

Testing Photographs and Procedure

N/A

Changelog

N/A

.github/CODEOWNERS Outdated Show resolved Hide resolved
@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Apr 11, 2024

(mappers can only merge mapping changes, as an example).

Seems like a good way to manage permissions without as much oversight.

Only question, for sprite/maptainers like pigeon, generally it's been fine for them to approve and merge icon/map changes, but if a pr has a single code change (like changing icon_state = "meat" to icon_state = "meatsteak"), would he no longer be able to merge it?

@PowerfulBacon PowerfulBacon marked this pull request as ready for review April 11, 2024 21:04
@Crossedfall
Copy link
Member

(mappers can only merge mapping changes, as an example).

Seems like a good way to manage permissions without as much oversight.

Only question, for sprite/maptainers like pigeon, generally it's been fine for them to approve and merge icon/map changes, but if a pr has a single code change (like changing icon_state = "meat" to icon_state = "meatsteak"), would he no longer be able to merge it?

Code owners isn't a determination for who can merge something, it just expresses responsibility for portions of the repository.

@Crossedfall Crossedfall added this pull request to the merge queue Apr 20, 2024
Merged via the queue into master with commit db35bed Apr 20, 2024
8 checks passed
@Crossedfall Crossedfall deleted the Updates-code-owners-to-use-a-mapping-team branch April 20, 2024 15:31
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
* Update CODEOWNERS to use a mapping team for maps

* Update .github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants