Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Display QoL. Unify brig timers under status displays. Emissivity and colored text! #10887

Merged
merged 12 commits into from
May 11, 2024

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Apr 14, 2024

About The Pull Request

Adds several new features, primarily to Status Displays:

  • Status & Newscasters are now emissive!'

ezgif-7-ed316345e5

  • Security Brig Timers are children of status displays, and use red text!
dreamseeker_YaSLAYDnny.mp4
  • Cargo shuttle timer uses orange text!

Screenshot 2024-04-14 144011

  • Updated the Communications console to use the same common status display JSX code.
  • Status display flowing text displays more nicely
  • Status displays now have circuit connectors!

Ports:

Why It's Good For The Game

Support for colored status display text, less shitcode. Less snowflaked machines. Status displays look less ass.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 rkz, TastyFish, Mothblocks
add: adds colored text support for status displays
add: Circuit support for status displays
rscadd: makes newscasters & status displays emissive!
fix: fixes hardels with Status Display vis_contents
fix: Status display marquee text flows nicer
/:cl:

@github-actions github-actions bot added Mapping DMM Change Sprites Tools TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Apr 14, 2024
@Tsar-Salat Tsar-Salat requested a review from a team as a code owner April 25, 2024 21:08
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR and good port that handles updating luminosity correctly.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue May 11, 2024
Merged via the queue into BeeStation:master with commit 8d614a5 May 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Fix Mapping DMM Change Removal Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants