Putting additional span srt_deadchat to deadsay for chat sorting
#10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
EvilDragonfiend
changed the title
deadsay to srt_deadchatsrt_deadchat to deadsay for chat sorting
|
Hmm, actually no. I think refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Putting additional span
srt_deadchattodeadsayfor chat sortingUsed regex:
["']{1}[a-zA-Z,\b_ ]*deadAs the previous PR described, style class being used as chat sort class is conceptually wrong.
This PR now corrects deadsay
Why It's Good For The Game
We want sort chats correctly
Testing Photographs and Procedure
Changelog
🆑
fix: messages will not be incorrectly sorted into deadsay category anymore
/:cl: