Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Xenoarchaeology #10906

Open
wants to merge 435 commits into
base: master
Choose a base branch
from

Conversation

DrDuckedGoose
Copy link
Contributor

@DrDuckedGoose DrDuckedGoose commented Apr 19, 2024

For those looking, this is also attached to the old wiki page-
https://wiki.beestation13.com/view/User:Racc-Off/new_artifacts

About The Pull Request

Commit Often :trollface:

Code

Rewrites the majority of xenoarchaeology code, vastly improving the old systems & implementations. The old code was pretty shit, and had quite a few bugs. These changes improve the majority of code, fixing most of the bugs I'm aware of.

Design

Improves multiple designs and interactions, generally introducing more depth to the shared systems. Overall improves how xenoarchaeology works in terms of department-to-department interaction, and how it functions within science. Previous pain points discussed by players have been addressed and handled in ways that integrate with improving the overall design & flow of artsci.

TODO

Finish relevant playtest todos:

  • Pearl trait initialization, to be or not to be
  • Science reward values
  • Tracker trait incompatibilities

For me

  • vary twin weights
  • Improve weights and conductivity to be more distinct
  • Add more trait hints
  • Add ability to negative-check traits in labeler
  • Add searching to labeler

Why It's Good For The Game

Improves almost every facet of the artifact experience, for players & coders alike

Testing Photographs and Procedure

Screenshots&Videos

image
image
image
image
image
image
image
image
image
image

Changelog

🆑
remove: Remove artifact pad
tweak: Improve artifact code
tweak: Reroute artifacts through cargo, adjusts artifact console
add: Add plethora of artifact traits
add: Add system for custom & player made artifacts
add: Add structures to deduce artifacts
add: Add structure to 'stabilize' artifacts
add: Add item to track artifacts
add: Stickers!
add: Sticker Gambling
/:cl:

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Dejaku51 Dejaku51 added the Frozen Frozen until a larger project is finished label Dec 17, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor

I know this is going to be slowed down by LINDA, but it looks like he fulfilled all your reviews dragon. Mind reviewing it again?

Copy link
Contributor

@Tsar-Salat Tsar-Salat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for dragon and bacon, but it looks good rn

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants