-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Dionae to the game #10919
Adds Dionae to the game #10919
Conversation
Oh yeah! So some servers have em enjoy radiation as well which shouldn't be terrible op here, also I think they usually starve and die when not in light (after some time), also also flash weakness? Saaaave for that the only big thing is the Dionea Nymph stuff for when they explode into bugs when they die. Also player panel stuff and probably a bunch of other things, but I am on phone and GitHub sucks on it lmao. Also also also thanks for putting up a draft so quick! |
@PowerfulBacon Hey just quickly poking you, were you thinking the idea with the Diona Nymphs being a plantable-respawn role thingy was a good idea? |
Yea, that sounds fine to me. Although they explicitly aren't respawns for your previous body (if you choose to enter your own planted pod) and will make you become a different person when spawning through them. |
Yeah, so it'd be fine if it worked like "Seed Planted in Botany Tray > Plant Grows > Ghostroll Prompt > New Body + Memories/Etc"? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What the fuck, why is the bot checking this? this is a DRAFT???? |
if(target in occupants) | ||
return | ||
if(pet_carrier_full(src)) //Run the checks again, just in case | ||
to_chat(user, "<span class='warning'>[src] is already carrying too much!</span>") | ||
return | ||
if(target.mob_size >= MOB_SIZE_HUMAN) // If the mob is small or smaller, no need for a do_after. | ||
if(!do_after(user, 3 SECONDS, target)) // If the mob is small or smaller, no need for a do_after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can merge two ifs together
|
||
/datum/species/diona/spec_death(gibbed, mob/living/carbon/human/H) | ||
var/mob/living/simple_animal/hostile/retaliate/nymph/drone = drone_ref?.resolve() | ||
if(drone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesnt matter, just set it to null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the stuff has been addressed, sorry but github trolled me
adult.set_species(SPECIES_DIONA) | ||
|
||
for(var/obj/item/bodypart/body_part in adult.bodyparts) //No limbs for you, small diona. | ||
if(!istype(body_part, /obj/item/bodypart/chest) && !istype(body_part, /obj/item/bodypart/head)) // If its not a chest AND not a head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could instead move the check for chest and head before this and with this you would be sure that this bodypart is not either
@@ -13,7 +13,7 @@ | |||
var/datum/sprite_accessory/stripe = GLOB.apid_stripes_list[stripe_name] | |||
|
|||
var/datum/universal_icon/icon_with_stripes = uni_icon('icons/mob/species/apid/bodyparts.dmi', "apid_chest_m", dir = SOUTH) | |||
if (stripe.icon_state != "none") | |||
if (stripe_name != FEATURE_NONE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings are case sensitive, it may break stuff
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This reverts commit e7b3dac.
About The Pull Request
Completes the dionae bounty (https://github.com/BeeStation/BeeStation-Hornet/discussions/10901), adds them to the game.
Majority of the code was ported from https://github.com/PolarisSS13/Polaris (Which is a fork of baystation, and neither of those repos actually have a PR that i can link that specifically add dionae, im now finding... Sorry!)
Credits to SS14's space-wizards/space-station-14#11497 PR for the eyes, brain, stomach and ears icons, as well as the main limbs and how the dionae look.
Credits to DungeonVR and Luxlator for the remaining sprites! (sadly i cant find their github accounts, but they're active in the discord, so i hope this is fine)
(The species was accepted by maintainers, ask @WhereAmO , im just here to code them in)
Why It's Good For The Game
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 EmoGarbage404, XeonMations, WhereAmIO, DungeonVR, Luxlator, Rukofamicom
add: Added Dionae to the game, a multi-organism plant person!
tweak: Changed all declarations from podperson to diona
remove: Removed Podperson plants from the game
add: New species trait: TRAIT_NORADDAMAGE
add: You can now grow nymphs in botany trays via nymph seeds, which replace podperson plants! Dead nymphs may also be planted to regrow a new one!
/:cl: