-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newfood: Plates #10920
Newfood: Plates #10920
Conversation
i dont even think i fixed a quarter of the plates to not have the inbuilt plate sprites yet gruh |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems good though
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
code/_onclick/hud/radial.dm
Outdated
@@ -242,7 +242,7 @@ GLOBAL_LIST_EMPTY(radial_menus) | |||
var/datum/radial_menu_choice/choice_datum = choice_datums[choice_id] | |||
if (choice_datum.info) | |||
var/obj/effect/abstract/info/info_button = new(E, choice_datum.info) | |||
info_button.plane = ABOVE_HUD_PLANE | |||
nfo_button.plane = ABOVE_HUD_PLANE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfo_button.plane = ABOVE_HUD_PLANE | |
info_button.plane = ABOVE_HUD_PLANE |
Woo \o/ Now I just need to add them to service Borgs |
About The Pull Request
Completely replaces the existing plate code with a new system.
Instead of plates being attached to food sprites directly, the instead are dispensed from the Kitchen vendor in three sizes: Small, Medium, and Large.
These plates use a new shattering component, where they will break if thrown.
In addition, anticipating the increased usage of Serving Trays by Cooks, they can now be attached to belts.
Ports:
RESPRITES (the old ones hurt my eyes):
Why It's Good For The Game
Necessary for ovens.
Also:
Old images were atrocious
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 rkz, PaxilManiac, Kryson, Qustinnus, nightred, Greniza, junkgle01
add: Separates plates from food sprites, into their own item. They come in three sizes, and break when thrown!
tweak: Serving Trays can now be attached to belts, anticipating its increased usage.
rscadd: resprites brioche, Vanilla, and ChocolateStrawberry cakes
code: removed duplicate update of plane, when layer is already changed
/:cl: