Wounds Atomization: Personalized Combat messages #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsar-Salat
commented
May 15, 2024
| @@ -112,6 +112,43 @@ | |||
| playsound(get_turf(src), I.get_dismember_sound(), 80, 1) | |||
| return TRUE //successful attack | |||
|
|
|||
| /mob/living/carbon/send_item_attack_message(obj/item/I, mob/living/user, hit_area, obj/item/bodypart/hit_bodypart) | |||
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Rukofamicom
approved these changes
Aug 11, 2024
Rukofamicom
added
Testmerge Passed
ss13-beebot
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This is a PR porting tg's personalized combat messages, essentially attack messages like "Attacker bludgeoned Receiver in the head with a Fireaxe!" only appear to surrounding spectating parties. What the Attacker sees is "You bludgeon Receiver's head with a fireaxe!" and etcetera for Receivers message.
This is applied to all items that had a unique attack message, simplemob attacks, and all help, harm, disarm intent messages.
Includes the framework for the combat messages that show when you inflict wound of varying intensity on other carbons.
Ports:
Partial Port:
Why It's Good For The Game
Wounds atomization, less message spam.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 rkz, Ryll/Shaps, KingofKosmos, Ghommie
add: personalized combat messages. Expect much more "you attack player" than "playername attacks player"
/:cl: