Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fires #11044

Closed
wants to merge 3 commits into from
Closed

Conversation

PowerfulBacon
Copy link
Member

@PowerfulBacon PowerfulBacon commented Jun 3, 2024

fixes #11039

About The Pull Request

Creates a new simple fire type that doesn't run on the atmos system. They require oxygen, but do not consume it, will merge and spread if big enough and will turn into atmospheric fires if they ignite the air.

Why It's Good For The Game

Fire from dragons and other non-atmopsheric sources won't last forever if atmos is pushed into the background. Also the fires from dragons will burn the floor tiles

Testing Photographs and Procedure

image

image

image

image

Changelog

🆑
tweak: Fires caused by space dragons, chemicals and other non-atmopsheric sources are now optimised to run at high time-dilations.
/:cl:

@PowerfulBacon PowerfulBacon marked this pull request as ready for review June 3, 2024 11:11
@ToasterBan
Copy link
Contributor

if these are different from gas fires it might be a good idea to give them a different sprite?

@PowerfulBacon
Copy link
Member Author

They process different from gas fires, but are intended to work in a way that makes it so its hard to tell the difference between them. If they are in flammable gasses, they will seemlessly convert into full gas fires.

@Rukofamicom
Copy link
Contributor

seamlessly

@Rukofamicom
Copy link
Contributor

Rukofamicom commented Oct 4, 2024

Fix lint issues and ping me (or self merge)

Just need a couple of undefines

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-fire caused hotspots should not be on the atmospherics subsystem
3 participants