Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports mech fixes part 2 #11149

Merged
merged 24 commits into from
Sep 11, 2024
Merged

Ports mech fixes part 2 #11149

merged 24 commits into from
Sep 11, 2024

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Jul 3, 2024

About The Pull Request

Part 2 of mech fixes.

This is collection of PRs from TG, intending to get Beestation mech code up to about 2022 TG standards. The purpose of this is to make it as simple as possible to convert our HTML mechcode to TGUI. Most of these PRs are refactors, but there are an additional few that are fixes.

In ascending order:

PR 1:
- Refactors medical mechtools

PR 2:
- Adds correct lazylist support for vehicle occupants (important for simplemob mech pilots)

PR 3:
- Fix runtime, bad log

PR 4:
- Clean up mech initialization
- Clean up HONKmech code


PR 5:
- Phazons no longer gain speed after phasing through certain objects
- Strips out deprecated movement delay system entirely

PR 6:
- If mech punch force is 0, they will not punch. (delineating between combat and working mechs)

PR 7:
- Autodocs mech_equipments
- removes unecessary duplicate vars

Ports:

TODO

Add testing for:

  • medical mech syringegun
  • simplemob mech movespeed
  • Roundstart mech works ok

Why It's Good For The Game

We are now one PR away from TGUI mechs.

The refactors are important, and the fixes are substantial for Savannah Ivanov

Testing Photographs and Procedure

Screenshots&Videos

Medical mecha

dreamseeker_kXZRMLFmnU.mp4

Changelog

🆑 rkz, TiviPlus, TemporalOroboros, Timberpoes, MLGTASTICa
refactor: refactors mech initialization
refactor: refactors medical mech tools
code: adds lazylist support for vehicle occupants
fix: Phazons no longer can exponentially increase speed by phasing through certain things...
/:cl:

@@ -292,6 +292,6 @@

/mob/living/simple_animal/hostile/syndicate/mecha_pilot/Goto(target, delay, minimum_distance)
if(mecha)
SSmove_manager.move_to(mecha, target, minimum_distance, mecha.movedelay * mecha.step_multiplier)
SSmove_manager.move_to(mecha, target, minimum_distance, mecha.movedelay)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real remaining use case of step_multiplier after the previous pr.

Gonna test that simple mobs respect the vehicles movement delay with the multiplier removed. That's really my only worry in this pr.

Player mobs driving mechs seems completely fine

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 9, 2024
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 11, 2024
Merged via the queue into BeeStation:master with commit 9bbc1cc Sep 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants