Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves security techfab to the warden room #11154

Closed
wants to merge 7 commits into from
Closed

Moves security techfab to the warden room #11154

wants to merge 7 commits into from

Conversation

DarnTheMarn
Copy link
Contributor

@DarnTheMarn DarnTheMarn commented Jul 4, 2024

About The Pull Request

Moves the security techfab from the security gear rooms to the wardens office

Why It's Good For The Game

Now people can't bypass the warden and HOS' decision on what to give out by simply printing their own mindshield pins, ion carbines, and telescopic shields.

Warden buff!

Testing Photographs and Procedure

evidence.1.mp4
Screenshots&Videos

Changelog

🆑
add: Added a new armory techfab to the armory, and placed the spare board in the HOS locker
tweak: Security techfab board is now in the wardens locker
tweak: Redistributed armory tier equipment to the armory techfab, this includes lethal ammo, weaponry, firing pins, shields, mech weaponry, and the like
/:cl:

@DarnTheMarn DarnTheMarn requested a review from a team as a code owner July 4, 2024 18:43
@github-actions github-actions bot added the Mapping DMM Change label Jul 4, 2024
@MarkusLarsson421
Copy link
Contributor

MarkusLarsson421 commented Jul 4, 2024

I like this, but it feels like both techfabs are then quite... barren in terms of amount of items available to be printed. I'd almost just move the entire security techfab to the armoury instead. And if it has to be constructed as you showed in the video, then I feel confident that it won't be used that often as you would need to get an ore silo link or shuffle resources over to it from the other techfab.

@DarnTheMarn
Copy link
Contributor Author

And if it has to be constructed as you showed in the video

It does not have to be constructed, I was just showing off where I put the spare board. As for the security techfab now lacking substance, yeah it does a little bit. But it still has enough useful things that moving everything to the armory one would be annoying.

@Fronsis
Copy link

Fronsis commented Jul 4, 2024

Good change, interesting to see how it's gonna play out! You basically didn't remove anything on armory per se you just stacked the objects to make space?

@DarnTheMarn
Copy link
Contributor Author

! You basically didn't remove anything on armory per se you just stacked the objects to make space?

The only thing that got removed was one of the standing flashers, so yeah nothing of use got removed.

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend you act on this immediately and wait for further dev input, but this feels like an overengineered solution - Security equipment should all come from the same fab for simplicity, and that fab should be located in the armory within the warden's purview on all maps.

Even for the simpler stuff that is printable, security having an extra layer to obtaining more gear than is initially laid out is good. In cases where there is nobody with armory access it sounds like a good excuse to promote existing security to being an HoS.

@MarkusLarsson421
Copy link
Contributor

Even for the simpler stuff that is printable, security having an extra layer to obtaining more gear than is initially laid out is good. In cases where there is nobody with armory access it sounds like a good excuse to promote existing security to being an HoS.

What if they had something like the Robotics Exosuit Fabricator? A Weapon Fabricator. Give it the same icon and such. Maybe require weapons to be assembled similar to Cyborgs and Mechs?

@DarnTheMarn
Copy link
Contributor Author

I'll wait for more feedback, but if splitting the techfab is off the menu I would like to place it in the warden's room not the armory for two reasons, it gives the warden a little more to do, and it prevents it being a free for all on the gaming techfab items as soon as the armory is open for whatever reason.

@Rukofamicom
Copy link
Contributor

Rukofamicom commented Jul 11, 2024

Already answered this in discord, but posting it here for public visibility:

I would like to place it in the warden's room not the armory

This is 100% fine with me, near identical level of restriction for all other parties and yet more convenient when it comes to the warden doing their job of controlling how extra equipment is distributed to security.

The original change request has been updated to reflect this as well in case this gets lost in conversation eventually

@DarnTheMarn
Copy link
Contributor Author

I won't include this in this PR whichever way it ends up being, but it would be interesting to add alert level checks to printing specific items. Some items like the Hades mech gun should be red alert since it's a lethally burning, indiscriminate weapon while something like the telescopic riot shield could be locked to blue alert since it's the equivalent of the normal riot shield you can get on blue.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PestoVerde322
Copy link
Contributor

PestoVerde322 commented Jul 17, 2024

Techfab for guns in armory, techfab for rest in office, and a reloading table for ammos ?wyci so you have to manually load your ammos instead of wasting materials by the techfab you greedy secoff/detective/deputized assistant >:(

@DarnTheMarn
Copy link
Contributor Author

I have been convinced. Considering the security techfab will have all of like 3 useful items to print, I'll go ahead and remove the armory techfab and push the security techfab to the wardens room. Having everything on one techfab will still make it a little opaque as to what is armory equipment and what isn't when compared to splitting items across two techfabs, but it'll still be better than how it is now. I'll look at adding alert level checks to the items in question at a later time as I said earlier.

@MarkusLarsson421
Copy link
Contributor

The alert check level would be great.

@Rukofamicom
Copy link
Contributor

Having everything on one techfab will still make it a little opaque as to what is armory equipment and what isn't

Ultimately as long as the fab is under the Warden's control I don't see this as an issue at all tbh.

Warden decides who gets what and when and there doesn't need to be a strict "this is allowed and this isn't" checklist.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DarnTheMarn DarnTheMarn changed the title Adds armory techfab, redistributes security techfab equipment to it Moves security techfab to the warden room Jul 20, 2024
@DarnTheMarn DarnTheMarn requested a review from Rukofamicom July 20, 2024 20:47
@DarnTheMarn
Copy link
Contributor Author

Since it got moved to the wardens room, they lose a photocopier on some maps and a table on others.

@Rukofamicom
Copy link
Contributor

You've requested my review but this is still conflicting

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog to reflect the actual changes and fix the conflicts and I'm 100% good with this change.

I will be seeking admin and other maint input before merging though.

Received input from admins and some sec players and it's generally positive with a bit of hesitance for lack of wardens, but agreed it just results in some forced entry by sec themselves (which already has to be done for armory if there's nobody to supply access when it is necessary)

@DarnTheMarn
Copy link
Contributor Author

We love map conflicts. Sorry about that

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DarnTheMarn
Copy link
Contributor Author

Directional lights merge conflicts got me fucked up. Closing this and opening a new PR that does the exact same thing since it's faster than solving all 300+ conflicts manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants