Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Syndicate Lavaland Outpost #11166

Merged
merged 18 commits into from
Nov 6, 2024

Conversation

MarkusLarsson421
Copy link
Contributor

@MarkusLarsson421 MarkusLarsson421 commented Jul 9, 2024

About The Pull Request

I think it looks better and it also replaces the old almost removed virology with a new recently reworked field.
The autolathes are placeholders until #10906 is finished and merged. Do not merge it until then.
Destroyed Xenoarch to look rundown and without any of the fancy computers and such, it can still be used to learn current day Xenoarch.

Why It's Good For The Game

Allows people to learn and try out this new field in relative peace and quiet.

The atmospherics changes will help fixing stuff such as when a fire bomb is tested in the chemistry grenade testing room.

Testing Photographs and Procedure

Screenshots&Videos

image

image

I'll playtest it some other day. I want feedback for these balance changes and such first.

Changelog

🆑
add: (Syndicate Outpost) Added a Xenoarch section.
del: (Syndicate Outpost) Removed Virology section.
tweak: (Syndicate Outpost) Added a hacked autolathe.
tweak: (Syndicate Outpost) Repositioned a few turrets.
tweak: (Syndicate Outpost) Added an atmosfan, full toolbelt and a heater.
fix: (Syndicate Outpost) Added some buffer walls to prevent turrets from shooting inwards through the station.
tweak: (Syndicate Outpost) Added another minor maintenance hallway.
tweak: (Syndicate Outpost) Minor tweaks all around.
tweak: (Syndicate Outpost) Expanded the bar and added an additional entrance.
tweak: (Syndicate Outpost) Did a bunch of decal work.
tweak: (Syndicate Outpost) Added a disposals input chute for the testing range.
fix: (Syndicate Outpost) Changed the atmos gas chambers to be filled with the respective gas on round start (O2, N2, Plasma).
fix: (Syndicate Outpost) Fixed so that the kitchen can actually cook food now.
fix: (Syndicate Outpost) Changed air distro to use layer 2 instead of 3.
/:cl:

@EvilDragonfiend
Copy link
Member

I think this will reward the station instead of them by research...

@MarkusLarsson421
Copy link
Contributor Author

Probably... Is that big of an issue? Once the PR is merged I might try to make a subtype which prevents all discovery related things.

Copy link
Member

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

missing pipe, unfitting white tile

image

missing outlet

image

new kitchen seems a little weird. dont really like the table here, and the lack of flooring under. also, mabye add some wooden borders around the wood?

image

a lot of wall decals around. intentional?

image
something seems to be wrong with the stairs

image
move up the layer of the railing

image
something seems wrong with the decalling under the closets

image
turrets target the pet. update its faction if your keeping it!


it shouldnt affect the stations research points :p
the syndicate wouldnt help the station

@spockye
Copy link
Member

spockye commented Jul 9, 2024

image

Dont give them the easter bunny. it spawns error eggs that can give you some pretty broken things
(nevermind. functionality has been removed from the bunny suit though it still spawns a lot of mess, still error eggs though)

@MarkusLarsson421
Copy link
Contributor Author

a lot of wall decals around. intentional?

image

@Rukofamicom
Copy link
Contributor

Rukofamicom commented Jul 10, 2024

Once the PR is merged I might try to make a subtype which prevents all discovery related things.

All PRs should be treated as final with no follow-ups expected, regardless of trust and/or history.

If this PR causes a problem that needs to be addressed, it should be included as part of this PR
If it is going to be two separate PRs, they should be functionally complete additions as separate PRs.

@MarkusLarsson421
Copy link
Contributor Author

I meant once the Xenoarch PR is merged. Making additions to their code would require me to make a fork of their code and deal with any up coming issues, so I wait until the Xenoarch PR is merged and try to add the additions myself to this PR then.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MarkusLarsson421
Copy link
Contributor Author

Where Xenoarch?

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed.

@github-actions github-actions bot added the Stale label Oct 31, 2024
@Rukofamicom Rukofamicom removed the Stale label Nov 2, 2024
Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rename the virology area since it isn't virology anymore.

@Rukofamicom Rukofamicom added this pull request to the merge queue Nov 6, 2024
@Rukofamicom
Copy link
Contributor

None of these changes constitute any real balance change for the capabilities of the outpost against intruders:
They still have sniper rifles and stechkins, and the turrets are still the same power as they were even if relocated.

Merged via the queue into BeeStation:master with commit b1ad941 Nov 6, 2024
21 checks passed
@MarkusLarsson421 MarkusLarsson421 deleted the syndie-outpost branch November 6, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants