Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Radstation atmos fix and changes. #11181

Closed
wants to merge 7 commits into from

Conversation

Geatish
Copy link
Contributor

@Geatish Geatish commented Jul 12, 2024

About The Pull Request

Fixed the atmos storage shutters not opening.
Removes the glass from the designated atmos area and rerouted undertile distro pipes around it.

Why It's Good For The Game

Shutters not being openable is bad. Tiles being where they aren't supposed to be any is bad. N2 in windows to gas chambers is bad, since they would contaminate the gas chambers if you were ever to destroy/remove the window.
The glass floor is not fire proof nor is it removable through conventional means, meaning that any atmos tech who wants to build a burn chamber there first has to burn or blow away the glass. The distro piping being unexpectedly in the way of atmos projects was is not fun at all.

Testing Photographs and Procedure

Screenshots&Videos

image

Atmos.changes.mp4

(note: the missing manifold pipes are there, the t-ray is just bugged.

Changelog

🆑 Geatish
tweak: Removed glass floor from the designated atmos work area and rerouted undertile distro piping around it.
fix: Rad station atmos storage shutters now work. Tiles in space next to gas miners have been removed. Plasma windows in gas chambers no longer spawn with N2. Also removed extra APC in xenobio
/:cl:

Rerouted distro piping around the designated work area, also removed the unremovable glass floor from there.
Finally fixed the atmosphereic shutters not being openable.
@Geatish Geatish requested a review from a team as a code owner July 12, 2024 21:24
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Jul 12, 2024

The glass floor is not fire proof

Swap it for rplasmaglass. I set that to be fireproof.

image

These mapchanges specifically were added by Floria, the map owner, so I assume it was part of their design for adding them.

The distro piping being unexpectedly in the way

I recommend marking the turfs with white decals, or put catwalk tiles over them. This will make them easily visible.

@Geatish
Copy link
Contributor Author

Geatish commented Jul 13, 2024

Swap it for rplasmaglass. I set that to be fireproof... These mapchanges specifically were added by Floria, the map owner, so I assume it was part of their design for adding them

Fair enough, I've asked Flora about this, since i think it looks kinda odd when you're building something on top of them and you can't really hide pipes under tiles.

I recommend marking the turfs with white decals, or put catwalk tiles over them. This will make them easily visible.

image

This is how it looked like before, having ANY distro pipes there is hell. Trying to do anything with the thermogen will 80% of cases force you to remove and reroute the distro piping. It doesn't make any sense for them to be anywhere in the designated zone, id rather just shrink and mark off the zone instead of labeling tiles as "you can't use these."

Geatish added 2 commits July 13, 2024 14:32
Fixed: Removed plating between the eastern miners and atmos. Fixed plasma glass tiles on gas chambers spawning with N2, making them contaminate the gas chamber if you were to remove the glass.
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Geatish added 2 commits July 18, 2024 17:21
also removed the extra apc in xeno.
Just dirt
@Geatish
Copy link
Contributor Author

Geatish commented Jul 20, 2024

Well shits fucked after pigeons map freeze and i cant seem to fix it. Some maint gotta step in.
Flora also stated that its fine if i remove the glass, since its not pretty once you start laying down pipes there.

@Geatish
Copy link
Contributor Author

Geatish commented Jul 21, 2024

Redoing the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants