Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates BoxStation and MetaStation Emergency Shuttles and Adds the Rage Cage Emergency Shuttle #11189

Merged
merged 47 commits into from
Sep 26, 2024

Conversation

ClownMoff
Copy link
Contributor

@ClownMoff ClownMoff commented Jul 14, 2024

About The Pull Request

1 more shuttle
Meta and Box shuttle rework

Why It's Good For The Game

Meta and Box old and clunky,

0-before

68747470733a2f2f616666656374656461726330372e626c6f622e636f72652e77696e646f77732e6e65742f6d6462322f696d616765732f3136323335363932372f32393038363737353339352f6d2f5f6d6170735f73687574746c65735f656d657267656e63795f

As for the new shuttle
The rage cage and the casino are fun alternatives to the regular shuttle

The Ultra Raven shuttle is a EXPENSIVE shuttle you call when you are dealing with a major threat and you need a way to 1.- GTFO and 2.- Minimize damage and maximize recovering people. It's the ultimate big thing you can get as crew that doesnt involve admin intervention, but you need 70k to order it. Comes with a insanely equiped medbay and an armory in the brig. I'm down to increase the prize even more, but I think a shuttle like this is an unique addition to the game that would reward shifts that have tons of money

Testing Photographs and Procedure

Screenshots&Videos

68747470733a2f2f616666656374656461726330372e626c6f622e636f72652e77696e646f77732e6e65742f6d6462322f696d616765732f3136323335363932372f32393036323531373131342f6d2f5f6d6170735f73687574746c65735f656d657267656e63795f

imagen

imagen

Changelog

🆑 Varo
add: Added a bew shuttle: THE RAGE CAGE
tweak: Gives the Meta and Box shuttles some love and a fresh layer of paint
fix: Adds a tiny fan to the Comically Large Escape Pod
/:cl:

@ClownMoff ClownMoff requested a review from a team as a code owner July 14, 2024 15:37
@github-actions github-actions bot added the Mapping DMM Change label Jul 14, 2024
@TsunamiAnt
Copy link
Contributor

could you add some oxy canisters to the ultra raven? In case of shuttle bombings the damage itself is usually repaired quickly, but all the air lost cannot be refilled.
Specifically oxy cans, because there's no way you can get full pressure with just a few cans. So pure oxy at lower pressure must do.

@ClownMoff
Copy link
Contributor Author

imagen

Are 2 enogh?

Copy link
Member

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with the casino.
im sorry but i really dont like it. its golden walls, golden floors, chairs and slot machines spammed everywhere, even infront of the doors, and a box on the side for medical.
theres no lights, no decalling, no windows, its just a square. personally i think it might be best to remove it from the PR. if not that a complete redo.

The Ragecage shuttle
im kinda having some of the same problems with this one as i have with the casino. little to no decalling, mostly empty, and its pretty plain. i dont think it really brings much to the table, since we already have the fighting arena on the ruski shuttle.

Now, on the ultraraven it might just be personal opinions but.
im not really a huge fan of the idea. its just a larger version of the raven, and the raven is already a amazing and powerful ship. i really dont think this version is necessary. a full armoury, two medbays. and im not a fan of how its laid out. i think it'll just end up being one of those things that cause a lot of issues at the end of rounds.

im sorry that this review is pretty negative, but i just felt i should say my two cents on the matter. if people disagree with me then thats totally fine!.

i'll include some issues not stated above under here:

requested changes

image
firelock in space

image
i dont think airlocks need firelocks

image
i think the turrets are facing the wrong way

image
something weird going on with the walls here

image
why is there a window here?

image

one firelock shutter, one armoury shutter with a blast door under, one with just a shutter and one with just a door? something weird is going on here.

image
these buttons are floating off the table

image
this room seems pretty empty and pointless, with there being another giant medbay in the middle.

image
i'd recommend giving your Shutters more unique ID's. hard to find later, and im unsure if that might conflict with other buttons

image
wild pipe

image
airlock isnt access locked

image
this feels VERY empty

image
door stuck

image
potentially moving around in this would be very akward. the floors also hurt my eyes

image
dont put a window here!

@Liver-1
Copy link
Contributor

Liver-1 commented Jul 16, 2024

Let's go gambling!

…i Toilet,Skibidi Toilet, Skibidi-Skibidi Toilet,Skibidi Toilet, Skibidi-Skibidi Toilet,Skibidi Toilet, Skibidi-Skibidi Toilet,Skibidi Toilet, Skibidi-Skibidi Toilet,
…AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
@ClownMoff ClownMoff marked this pull request as ready for review August 22, 2024 00:20
_maps/shuttles/emergency/emergency_casino.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_casino.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_casino.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_casino.dmm Outdated Show resolved Hide resolved
code/datums/shuttles.dm Outdated Show resolved Hide resolved
code/datums/shuttles.dm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_ragecage.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_ultraraven.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_meta.dmm Outdated Show resolved Hide resolved
_maps/shuttles/emergency/emergency_box.dmm Outdated Show resolved Hide resolved
@ClownMoff ClownMoff changed the title Shuttle Updates And Additions Shuttle Updates And Addition Aug 28, 2024
Copy link
Contributor

@PestoVerde322 PestoVerde322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to go, approved.

@ClownMoff ClownMoff changed the title Shuttle Updates And Addition Updates BoxStation and MetaStation Emergency Shuttles and Adds the Rage Cage Emergency Shuttle Sep 18, 2024
@PestoVerde322 PestoVerde322 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into BeeStation:master with commit 8914a24 Sep 26, 2024
21 checks passed
@Fronsis Fronsis mentioned this pull request Sep 27, 2024
@Rukofamicom
Copy link
Contributor

This PR contains undocumented changes.

A fresh coat of paint should not include new items without documenting them for proper consideration. Making undocumented changes can result in repo bans if it is determined the information was intentionally withheld.

I'm referring to the expansion of medbay capabilities via adding defib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants