Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeltaStation2 New Brig (and minor fixes/adjustments - Fluked PR edition #11218

Merged
merged 11 commits into from
Aug 31, 2024

Conversation

PestoVerde322
Copy link
Contributor

@PestoVerde322 PestoVerde322 commented Jul 20, 2024

About The Pull Request

This is literally the same pr as #10697, same ordeal really, I fluked up the original PR, so here we are.

This PR overhauls completely the brig for Delta2, and also rearrange some stuff to fit more the overall aesthetic and functionality of the brig, this also modifies the crew quarters a bit and the cargo dock, while also fixing some leftovers from other PRs.

Why It's Good For The Game

Better map good? (and less Git flukery, hopefully so)

Testing Photographs and Procedure

Screenshots&Videos

immagine

Changelog

🆑
add: [DeltaStation2] Rearranged essentially amost all of the brig surroundings and the brig itself.
fix: [DeltaStation2] Removed some misc leftovers.
fix: [DeltaStation2] The disposals now no longer go trough walls, and instead goes either under windows or more preferably, under doors as intended by any sane mapper.
/:cl:

A horrible mistake
@PestoVerde322 PestoVerde322 requested a review from a team as a code owner July 20, 2024 19:47
@github-actions github-actions bot added the Mapping DMM Change label Jul 20, 2024
Copy link
Member

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

small cabling error. couldnt find anything else at the moment!

Copy link
Member

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

the button doesnt unbolt the door

image

now this cant be right...

image

A lot of floating APC's around.

image

three apc's in one area.

everything else looks good though!

Copy link

github-actions bot commented Aug 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon
Copy link
Member

image

Is it meant to have these?

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 31, 2024
Merged via the queue into BeeStation:master with commit 4913a94 Aug 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants