-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] Adds crate shelves to the game #11229
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Why don't the crates stack neatly like they do in the shiptest PR? This just looks very janky because it doesn't actually stack the crate sprites in any way. The tops of the crates should be covered by the empty shelf or crate above them. Reference images for those who don't want to compare: |
Failing new checks You'll need to define the |
if(get_dist(drop_atom, src) != 1 || get_dist(drop_atom, user) != 1) | ||
return // Check whether the crate is exactly 1 tile from the shelf and the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check to see if the crate is next to the user, rather than if the crate is next to the shelf so that you can drag a crate onto a shelf when it is behind you and not adjacent to the shelf.
2024-09-11.16-26-36.mp4 |
About The Pull Request
Adds crate shelves to the game, craftable from an iron sheet.
Ported from Shiptest's GenericDM's #2374 PR
Updated crate shelf sprite from @MarkusLarsson421
Updated crate shelf parts sprite from @ClownMoff
To do:
Why It's Good For The Game
Gives crates a third dimension to go, allowing them to be stacked is good for cargo's crate supply.
Testing Photographs and Procedure
Screenshots&Videos
2024-07-24.19-30-33.mp4
Changelog
🆑 Generic DM, PositiveEntropy, Markus Larsson, ClownMoff, XeonMations
add: Added crate shelves to the game!
/:cl: