Fixed repeating categories in the crafting menu and sorted all the recipes #11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2024 15:37
if i see anything that looks odd, i'm gonna punt somoene
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
added 2 commits
August 27, 2024 13:33
I mergefix hoping it's all good to go
PowerfulBacon
requested changes
Aug 27, 2024
Comment on lines
6
to
18
| var/reqs[] = list() | ||
| //type paths of items explicitly not allowed as an ingredient | ||
| var/blacklist[] = list() | ||
| //type path of item resulting from this craft | ||
| var/result | ||
| //type paths of items needed but not consumed | ||
| var/tools[] = list() | ||
| //time in deciseconds | ||
| var/time = 30 | ||
| //type paths of items that will be placed in the result | ||
| var/parts[] = list() | ||
| //like tools but for reagents | ||
| var/chem_catalysts[] = list() |
There was a problem hiding this comment.
Change these to use var/list/name
| //type paths of items needed but not consumed | ||
| var/tools[] = list() | ||
| //time in deciseconds | ||
| var/time = 30 |
There was a problem hiding this comment.
If you are moving time around, you might as well change this to 3 SECONDS and use time defines instead.
PowerfulBacon
approved these changes
Aug 28, 2024
|
Actually just remembered my prior review |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PowerfulBacon
approved these changes
Sep 9, 2024
ss13-beebot
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR fixes the repeating categories in the crafting menu as certain items on the crafting list were repeating (See Egg-Based Food).
However, the bulk of this PR is that i sorted and standardized all the recipes in the game under the
components/craftingfolder, meaning that not only all the recipes are there, but they're not in a massive unorganized list anymore.Why It's Good For The Game
Fixes and coding QoL good.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
fix: Fixed repeating categories in the crafting menu.
refactor: Sorted and standardized all the recipes, please DO NOT put the recipes outside of that folder and stick to the format of all the other recipes.
code: Rebalanced the times to craft and interaction of some recipes.
/:cl: