Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluespace cannon update #11286

Merged
merged 15 commits into from
Aug 16, 2024
Merged

Bluespace cannon update #11286

merged 15 commits into from
Aug 16, 2024

Conversation

Dejaku51
Copy link
Contributor

@Dejaku51 Dejaku51 commented Aug 3, 2024

About The Pull Request

  • integrated battery charged from a wire connected to the back of the BSA
  • sounds for windup and shooting
  • during the windup there are sparks around the place where cannon will shoot
  • back part of the BSA shows charge in quarters also makes a sound each quarter charged (unique for full)
  • now requires 5MW instead of 2MW
  • bsa doesn't have charge speed limit

might also change the laser to use particles in the future

Why It's Good For The Game

BSA using APC in the area doesn't make sense for such a big gun
big gun like that wouldn't be silent when shooting
more vfx and sfx good

Testing Photographs and Procedure

Screenshots&Videos
output.mp4

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: BSA now has a windup with sparks on target location
add: BSA now has integrated battery and is powered with a cable attached to the end of BSA
add: BSA shows amount of charge in quarters on the capacitor part of the BSA
balance: BSA requires 5MW to shoot
soundadd: BSA now makes a sound when winding up and shooting
soundadd: BSA makes a sound on quarters charged with unique one on full charge
/:cl:

@github-actions github-actions bot added Sprites Sound TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Aug 3, 2024
@MarkusLarsson421
Copy link
Contributor

Roughly how many shots can be fired in a full charge and can it be expanded?

@Dejaku51
Copy link
Contributor Author

Dejaku51 commented Aug 3, 2024

Roughly how many shots can be fired in a full charge and can it be expanded?

you need full charge to shoot once, can't be expanded

@MarkusLarsson421
Copy link
Contributor

MarkusLarsson421 commented Aug 3, 2024

Pretty please? Let us connect additional SMES to it directly or such!

Edit: Will adding more power output charge it faster perhaps? Such as four upgraded fully charged SMES set to max output.

@Dejaku51
Copy link
Contributor Author

Dejaku51 commented Aug 3, 2024

Pretty please? Let us connect additional SMES to it directly or such!

Edit: Will adding more power output charge it faster perhaps? Such as four upgraded fully charged SMES set to max output.

more power means faster charging yes, even currently there is no charge speed limit

@Rukofamicom
Copy link
Contributor

no charge speed limit

If it ends up being abused regularly this is something that can be added later.
This looks pretty cool imo

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'd suggest,, but not worth blocking over is that the sparks at the target location be blue instead of normal sparks.

@Dejaku51
Copy link
Contributor Author

unknown_2024.08.15-14.46.mp4

@PowerfulBacon
Copy link
Member

I trust ruko's review of the code

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 16, 2024
Merged via the queue into BeeStation:master with commit 86bb519 Aug 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance/Rebalance Feature Sound Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants