Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks Service Pistol stats #11315

Merged
merged 7 commits into from
Aug 10, 2024

Conversation

Rukofamicom
Copy link
Contributor

@Rukofamicom Rukofamicom commented Aug 10, 2024

About The Pull Request

  • Mag size 10 -> 12
  • Magazine sprite tweak to match new capacity
  • Burn per shot 10 -> 11
  • Extra magazine in every head locker (HoS had to lose box of flashbangs for this)

Why It's Good For The Game

Service pistol aimed to be a minor improvement over the PTSD but failed to accomplish this by being substantially weaker both as a stun weapon and as a lethal weapon. The tweaked stats mentioned above allow the service pistol to:

  • Have the same number of shots as PTSD did in disabler mode, while having a hybrid damage split that makes them weaker as a disabler
  • Have an extra clip available to make the overall output actually higher than PTSD, instead of roughly the same. Still substantially lower DPS than other energy weapons
  • Have just a little more oomph when it comes to the lethal output vs simplemobs and such.

Testing Photographs and Procedure

Screenshots&Videos

image

image

image

image

Changelog

🆑
balance: Service pistol has modestly improved stats: 12 shots up from 10, 10% more burn damage, and an extra magazine is now available in all head lockers.
tweak: Adjusted service pistol magazine sprite to accommodate increased capacity.
tweak: Box of flashbangs has been removed from HoS locker to make room for the extra magazine.
/:cl:

Mag size 10 -> 12
Burn per shot 10 -> 12
Stam per shot 18 -> 23
@Rukofamicom
Copy link
Contributor Author

I originally added a light overlay but I cba to fix the fact they don't work with non-energy pistols.

@Rukofamicom
Copy link
Contributor Author

Rukofamicom commented Aug 10, 2024

I like how the new hybrid damage type plays out, but I do think this would still be cooler if the magazines were slowly self-charging

@MarkusLarsson421
Copy link
Contributor

I do think this would still be cooler if the magazines were slowly self-charging

The slow self-recharge feature was so slow it was painful. Missed all your shots? Now you got to wait for 10 whole minutes for it to recharge! That's what it feels like at least. It was really painful.

Comment on lines 43 to 44
damage = 11
stamina = 25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamian damage should be strictly lower than the stamina damage output of the disabler. All other things like increased ammo are fine, I was planning to put rechargers back in the heads offices.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather the DPS be lower and they be given backup clips or the capability to recharge instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra magazine has been added to each locker. I still don't like the idea of being able to create or order additional mags personally, but if it's limited to a single one for heads it should be fine.

@Rukofamicom
Copy link
Contributor Author

Well fuck
Now the HoS locker is overloaded.

@Therealdoooc213
Copy link
Contributor

Maybe you could remove the flashbang box instead of the telescopic shield? I don't think I've seen anyone take the flashbang box and the riot shield is very useful.

@Rukofamicom
Copy link
Contributor Author

That was my other choice and Bacon agrees.

Both flashbangs and riot shields are available in the rest of sec, so the swap is inconsequential to me.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 10, 2024
Merged via the queue into BeeStation:master with commit 2110b45 Aug 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants