Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental stamina fix #11323

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

Tsar-Salat
Copy link
Contributor

About The Pull Request

Somethings off with the stamina calculation as of late.

At first I thought it was simply not obeying the CLAMP max, but that turned out not to be the case, #11322 You CAN have up to 360 total stamina damage, adding all the limbs together, its not limited to 100 as someone suggested.

I've narrowed it down to what I believe should make the decrease better, namely, as soon as we hit stamcrit, we want to dump a lot of stamina very quickly, and mitigate incoming stamina.
If we don't, you end up with scenarios where someone can spend 160 seconds on the floor, basically making it seem like its not going down at all.

Why It's Good For The Game

Should put us back around what it was before. Only what I've tested though. Probably could use a TM.

Testing Photographs and Procedure

Screenshots&Videos

Currently

dreamseeker_eyJlXGKDqX.mp4

After this PR

dreamseeker_edjrRUhwEt.mp4

Changelog

🆑 rkz
fix: possibly fixes stamina healing
/:cl:

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 15, 2024
Merged via the queue into BeeStation:master with commit 2299eb4 Aug 15, 2024
8 checks passed
@Tsar-Salat Tsar-Salat deleted the experimental-stamina-fix branch October 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants