Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes subsystems warnings #11334

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

Dejaku51
Copy link
Contributor

@Dejaku51 Dejaku51 commented Aug 15, 2024

About The Pull Request

makes zfall and elevator controller not initialize
Natural Light Cycle subsystem will now disable if map doesn't have config turned on, fail entirely if doesn't have cycle colors set and work fine if no errors

Why It's Good For The Game

warnings bad

Testing Photographs and Procedure

Screenshots&Videos

Box
image
image

Echo
image
image
image

Changelog

🆑
code: Zfall and Elevator controller doesn't init anymore
fix: Natural Light Cycle subsystem inits correctly
/:cl:

@Crossedfall
Copy link
Member

For your tests, load up Box station and ensure that the natural light cycle SS doesn't fire. Then load up Echo and see if it correctly starts firing.

@Dejaku51
Copy link
Contributor Author

Dejaku51 commented Aug 16, 2024

updated testing evidence photos

@EvilDragonfiend EvilDragonfiend added this pull request to the merge queue Aug 22, 2024
Merged via the queue into BeeStation:master with commit 9ec9eb3 Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants