Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Trait: Pet Lover #11341

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

New Trait: Pet Lover #11341

wants to merge 13 commits into from

Conversation

ClownMoff
Copy link
Contributor

@ClownMoff ClownMoff commented Aug 18, 2024

About The Pull Request

Title.

imagen

Why It's Good For The Game

Everyone needs a best friend

Testing Photographs and Procedure

Screenshots&Videos

imagen

The monkey doesn't appear on this video, I added it later

8mb.video-0T0-YHC0x6DJ.mp4

Changelog

🆑
add: New trait: Pet lover. Comes with a pets beacon to summon a new friend, a pet carrier and a collar.
/:cl:

@ClownMoff
Copy link
Contributor Author

I wasn't able to make it so you can name the pet before the wheel appears and I don't know if you can make it so you can do it after you select an option you can name it before the package is sent. If someone wants to help, it would be appreciated.

code/game/objects/items/miscellaneous.dm Outdated Show resolved Hide resolved
code/game/objects/items/miscellaneous.dm Outdated Show resolved Hide resolved
code/game/objects/items/miscellaneous.dm Outdated Show resolved Hide resolved
@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Aug 18, 2024

aw, github doesn't recognise one line change.
I mean monkey, clown, and goat shouldn't be included.

@ClownMoff
Copy link
Contributor Author

ClownMoff commented Aug 18, 2024

Why not? I can see the clown reasoning but you can already get a monkey at hydroponics desk, why cant you get another as a pet?

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Aug 18, 2024

Why not? I can see the clown reasoning but you can already get a monkey at hydroponics desk, why cant you get another as a pet?

quirks are not supposed to provide such high impacting gameplay beneficial when it can provide a lot of flexibility.

  • Monkey: you can pick monkey when you just specifically need one rather than having other pets.
  • Goat: Good for against vines
  • Clown: just no. you know why alraedy.

These are not for 1 point quirk.

@ClownMoff
Copy link
Contributor Author

Fine

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the rare pets, the rare corgis and rare kittens.

@ClownMoff
Copy link
Contributor Author

I did btw

code/datums/traits/positive_quirk.dm Outdated Show resolved Hide resolved
code/game/objects/items/miscellaneous.dm Outdated Show resolved Hide resolved
@RDS88-beeman
Copy link
Contributor

lizard please

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nakalon
Copy link
Contributor

Nakalon commented Sep 15, 2024

pretty cool now i can shove my own pet into washing machines

@Rukofamicom Rukofamicom added the 🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed label Oct 4, 2024
@Rukofamicom
Copy link
Contributor

I'm not strictly against this being added so the key can be ignored by other maints, but I don't think this adds meaningful content to the game and is mostly just a little more bloat.

When discussing with head coder I was told it is appropriate to key PRs I feel this way about instead of leaving them stuck in limbo with no reviews.

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRAIT_PETLOVER is not necessary

Copy link
Contributor

@Tsar-Salat Tsar-Salat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find PRs like this problematic if they already have a use through interacting with departments.

IC, pets are generally a departmental thing, with the ability to add more through cargo.

I don't really see the purpose of this pr. Maybe if it came with a trauma for protecting the pet and the pet being a detriment to the player, and it dying being a major blow. I think that will be creative way to implement this.

It just being a pet beacon for 1 point is boring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed 🔑 Close Key (2/3) Feature Sprites Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants