-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Trait: Pet Lover #11341
base: master
Are you sure you want to change the base?
New Trait: Pet Lover #11341
Conversation
I wasn't able to make it so you can name the pet before the wheel appears and I don't know if you can make it so you can do it after you select an option you can name it before the package is sent. If someone wants to help, it would be appreciated. |
aw, github doesn't recognise one line change. |
Why not? I can see the clown reasoning but you can already get a monkey at hydroponics desk, why cant you get another as a pet? |
quirks are not supposed to provide such high impacting gameplay beneficial when it can provide a lot of flexibility.
These are not for 1 point quirk. |
Fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove the rare pets, the rare corgis and rare kittens.
I did btw |
lizard please |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
pretty cool now i can shove my own pet into washing machines |
I'm not strictly against this being added so the key can be ignored by other maints, but I don't think this adds meaningful content to the game and is mostly just a little more bloat. When discussing with head coder I was told it is appropriate to key PRs I feel this way about instead of leaving them stuck in limbo with no reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TRAIT_PETLOVER
is not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find PRs like this problematic if they already have a use through interacting with departments.
IC, pets are generally a departmental thing, with the ability to add more through cargo.
I don't really see the purpose of this pr. Maybe if it came with a trauma for protecting the pet and the pet being a detriment to the player, and it dying being a major blow. I think that will be creative way to implement this.
It just being a pet beacon for 1 point is boring.
About The Pull Request
Title.
Why It's Good For The Game
Everyone needs a best friend
Testing Photographs and Procedure
Screenshots&Videos
The monkey doesn't appear on this video, I added it later
8mb.video-0T0-YHC0x6DJ.mp4
Changelog
🆑
add: New trait: Pet lover. Comes with a pets beacon to summon a new friend, a pet carrier and a collar.
/:cl: