Pacifies all pets spawned by Xenobiology's Stabilized Gold

[aramix273]

About The Pull Request

for all I can tell, the pet spawned by stabilized gold should be a pacifist
the pseudo-immortality is biggest argument in this sense
it's still a good question why there are hostile animals in friendly paths and why they have the FRIENDLY_SPAWN tag despite their attacks (perhaps referring to their default AI rather than capacity to harm, which is kind of an edge case considering sentience)

Why It's Good For The Game

Fixes: #11328

you can no longer have stabilized gold pets that can bite and poison you then come back each time you kill them
though they can still ventcrawl, pull and strip
took this route rather than removing the snake and lizard from the pool outright because:

• it allows them to be pets still,
• this should cover any other cases if pets were to be added to this

Testing Photographs and Procedure

Screenshots&Videos

pacifytesting2.mp4

Changelog

🆑 Aramix
tweak: pacified all pets spawned by Xenobiology's Stabilized Gold
/:cl:

[aramix273]

should ideally solve #11328 too (testing evidence shows so) while keeping code/mechanic changes local to stabilized gold and without modifying simple_animal code

[EvilDragonfiend]

why don't you just give them pacifist trait?

[aramix273]

why don't you just give them pacifist trait?

did not come to mind to use it
apparently the parrot does not care about the proc that I registered that is supposed to cancel attacks
so, pacifism would help, albeit only for attacking mobs
apparently, even though the parrot has 0 obj_damage, it can still hurt walls and other structures while melee_damage is non-zero,, so that has to be set to 0 too

[aramix273]

applied my last observations and had to handle a particular case of parrots being able to just change their melee_damage via "Toggle Mode"
this is getting a bit convoluted for the purpose of also disabling such a pet's capacity to damage structures, so if the PR's scope or implementation is getting a bit snowflakey, it could be reduced to pacification against just mobs, at expense of potential later abuse to break structures such as consoles or whatnot

[RDS88-beeman]

As (I would like to imagine) the primary abuser of this bullshit, please hit burning yellow next.
Also, I approve this message.