Fixes runtimes when eminances are damaged #11351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The issue:
Any time an eminence takes damage, it creates a runtime while updating its health. This Just today we saw a massive amount (10000+) of this runtime produced during a single round, which shows that it can be problematic (still have yet to recreate whatever happened to cause such rapid health hud updates, which is just as concerning as this)
Why It's Good For The Game
Less runtimes = smoother running code = better game.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
fix: Eminences no longer attempt to update a non-existent health hud
code: Changed a few stack traces in hud code to crashes for less obfuscated runtimes
/:cl: