Major ModPC Refactor: Mainboards and Componentized Logic #11371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Administration
TGUI-Changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds the mainboard intermediary object which holds all the PC components like CPU and hard drives. That mainboard is then inside of the modular computer item for Laptops, Tablets, and PDAs, and the modular computer machine for consoles and such.
While I am at it I might as well make it into a component, that's why I need a bunch of new signals to be available so AIs and Cyborgs can participate in the fun.
Mandatory prerequisites:
Todo:
Why It's Good For The Game
Moving pretty much all the code away from
/obj/item/modular_comptuer/cpuseems like a really good idea and gives us more flexibility to have ModPCs be usable for much more different use-cases (research into /mob ModPCs still in progress)Turning ModPCs into components allows us to have more flexible code
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
add: ModPC mainboards
refactor: Refactors ModPCs to use an intermediary object, mainboard, to store all the logic instead of a subtype
refactor: Adding ModPC logic is now componentized
/:cl: