Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decal bolts #11423

Closed
wants to merge 1 commit into from
Closed

Conversation

DrDuckedGoose
Copy link
Contributor

@DrDuckedGoose DrDuckedGoose commented Sep 3, 2024

About The Pull Request

At some point, bolts were added to the corner of decal sprites. This reverts that.
Personally, I don't it makes sense, since regular tiles don't have bolts, and decals are supposedly just painted on.

If someone wants bolts specifically, I think they should make a seperate decal that can be added to a tile, instead of making all decals bolted.

Why It's Good For The Game

Corrects styling?

Testing Photographs and Procedure

Screenshots&Videos

with bolts
image

without bolts
image

image
image

Changelog

🆑
tweak: Tweaks decal sprites to look more sensible
/:cl:

@MarkusLarsson421
Copy link
Contributor

Not gonna lie, I like those bolts. It was a minor detail to differentiate them from normal tiles.

@DrDuckedGoose
Copy link
Contributor Author

I think we should either go all in on bolts, or have none at all

@MarkusLarsson421
Copy link
Contributor

I mean... no reason for it to conform to the norm. Is there? Although if so, all bolts would look better.

@DrDuckedGoose
Copy link
Contributor Author

DrDuckedGoose commented Sep 3, 2024

I mean... no reason for it to conform to the norm. Is there?

When trying to cultivate a semi uniform visual style, there certainly is.

Although if so, all bolts would look better.

If we do, the bolts need to have more contrast. The color used for the current ones isn't contrasted enough, and creates some visual artifacts, like making them seem bigger than they are on monitors like my own.

@PowerfulBacon
Copy link
Member

PowerfulBacon commented Sep 3, 2024

Could you show a comparison between tiles from being on a turf?

@DrDuckedGoose
Copy link
Contributor Author

Could you show a comparison between tiles from being on a turf?

Done, checkout the testing images.
They're just too faint, and they conflict with the current style logic. I think if we want bolts, they need better contrast and most tiles should have them

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is near impossible to spot anyway and if we have bolts they should be on all tiles and not just painted ones

@PowerfulBacon
Copy link
Member

I actually quite like the bolts, they give a lot of flavour to some areas and are noticable actually.

image

@DrDuckedGoose
Copy link
Contributor Author

Then we should commit to then, instead of having them exclusively on decals

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Sep 11, 2024

image

The duality of man.

As original PR author, I'm fine with removal or a tile change.
If Racc says its not sensible, I believe him. He set the tiling standard.

@PowerfulBacon
Copy link
Member

Noticed it in game where there are areas where you can tell, the screenshots do a poor job at showcasing the differences between an area where it makes significant differences.

@DrDuckedGoose
Copy link
Contributor Author

My bad pimp
If you like them, I can try making us bolt station. I'd just like some consistency

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed.

@github-actions github-actions bot added the Stale label Oct 16, 2024
@github-actions github-actions bot closed this Oct 28, 2024
@DrDuckedGoose DrDuckedGoose deleted the revert-bolts branch October 29, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants