Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New walls and girders (now with smoothing!) + spare fixes #11427

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

PestoVerde322
Copy link
Contributor

@PestoVerde322 PestoVerde322 commented Sep 4, 2024

About The Pull Request

This PR implements a new style of walls and girders, which now are also smooth when built next to eachother.

Why It's Good For The Game

Old walls and girders are a relic of the early 2010s era, as much they're dear to everyone, it's time to let go.

Testing Photographs and Procedure

Screenshots&Videos

immagine

immagine

On PowerfulBacon's request
immagine

Changelog

🆑
add: Girders and their reinforced variant are now a smooth structure.
imageadd: Replaced the outdated Walls and girders icons.
code: Put some order in the indestructible walls and gave them their own folder (excluding the Hilbert hotel's unique turfs)
fix: Wooden walls and Silver walls are now opaque again
/:cl:

@Geatish
Copy link
Contributor

Geatish commented Sep 4, 2024

Already making a beecode wallstation

@PestoVerde322 PestoVerde322 changed the title New walls and girders (now with smoothing!) New walls and girders (now with smoothing!) + spare fixes Sep 4, 2024
@RDS88-beeman
Copy link
Contributor

Muh Sovl!

In all seriousness, this is cool, but what about. All the other walls. Like the paper one, and the wooden one, and the bamboo one, and

@PestoVerde322
Copy link
Contributor Author

In all seriousness, this is cool, but what about. All the other walls. Like the paper one, and the wooden one, and the bamboo one, and

I plan to do them in a future update, this is just a groundstart for now and I didn't feel to make the PR overextended.

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Sep 4, 2024

This is hot 🥵

@Sadboysuss
Copy link

wow that's beatiful

@RDS88-beeman
Copy link
Contributor

Fair enough. Is this supposed to nuke Cordons? Since it seems like it nukes cordons.

@PestoVerde322
Copy link
Contributor Author

Fair enough. Is this supposed to nuke Cordons? Since it seems like it nukes cordons.

Nope! It moves them to code/game/turfs/closed/indestructible.dm instead, where there's all the wall/indestructible instances (except for the hilbert's as it has some weird interactions).

and unwrenched girders have been permanenetly unsmoothed
@Rukofamicom Rukofamicom added the Golden ⭐ For high-effort PRs that make big and good improvements to the game. label Sep 4, 2024
@PowerfulBacon
Copy link
Member

These look absolutely excellent

@ike709
Copy link
Member

ike709 commented Sep 4, 2024

I'm indifferent about most of this but those reinforced walls look awful.

@Tsar-Salat
Copy link
Contributor

Reinforced walls could use some touchups on their smoothing

@PowerfulBacon PowerfulBacon reopened this Sep 8, 2024
@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label Sep 8, 2024
@PowerfulBacon
Copy link
Member

PowerfulBacon commented Sep 8, 2024

The smoothing on the R-walls make them look a bit boxed out

image

It would be nice if the lines at the edge of the tiles were somehow changed to make them look like less individual tiles and more like a continuous wall.

image

It would be interesting to see walls where the high part of them is offset upwards, so they look more like they are being observed from an angle (rather than from top down) in the future since the perspective does throw you off a bit if you look at the walls only in relation to the other items around them.

@Programs-The-Station
Copy link
Contributor

I like the style of the normal walls, but I think the smoothing groups need to be expanded a bit.

For instance, the walls should probably smooth to airlocks and windows, because this angling makes it seem like there's a V groove between the window/airlock and the wall.
image

In addition, wall mounts now kinda look out of place, because they cross 2 or 3 sides now. Like the intercom and pepper spray dispenser here.
image
It's like the intercom is stuck on the top surface of the wall, and hanging off the front side.

@PestoVerde322
Copy link
Contributor Author

I like the style of the normal walls, but I think the smoothing groups need to be expanded a bit.

For instance, the walls should probably smooth to airlocks and windows, because this angling makes it seem like there's a V groove between the window/airlock and the wall. image

In addition, wall mounts now kinda look out of place, because they cross 2 or 3 sides now. Like the intercom and pepper spray dispenser here. image It's like the intercom is stuck on the top surface of the wall, and hanging off the front side.

As I've said in the discord, for now this PR focuses on the (iron) walls and girders since i didn't want to overscope the PR; however I'll take those in account for the following PRs.

@Programs-The-Station
Copy link
Contributor

As I've said in the discord, for now this PR focuses on the (iron) walls and girders since i didn't want to overscope the PR; however I'll take those in account for the following PRs.

Yep, I know that you are only focusing on the walls. I just wanted to bring it up because I don't want this to become a Wallening where the project gets left in a half finished state (not saying that you would do that, just making sure the wall mounts were on the radar for the PRs in the future).

@llol111
Copy link
Contributor

llol111 commented Sep 14, 2024

Im not a fan of changing the wall sprites at all, tbh. Wierd ass sloped triangle looking stuff.
But... these are infinitely more tolerable than the shit TG pulled. Im just whining, these are not that bad.

@Tsar-Salat
Copy link
Contributor

Im not a fan of changing the wall sprites at all, tbh.

12 years.

Bay station has newer walls than us.

@llol111
Copy link
Contributor

llol111 commented Sep 15, 2024

Im not a fan of changing the wall sprites at all, tbh.

12 years.

Bay station has newer walls than us.

neither of those things are an argument

@ToasterBan
Copy link
Contributor

it took me 20 minutes of playing to even notice these changes, upgrading the sprites while keeping a very similar look, very well done

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 23, 2024
@PowerfulBacon
Copy link
Member

They are essentially official at this point with how long they've been on

Merged via the queue into BeeStation:master with commit 4e8bcc6 Sep 23, 2024
22 checks passed
mystery3525 pushed a commit to mystery3525/BeeStation-Hornet that referenced this pull request Sep 25, 2024
…#11427)

* new walls pt1

* and now girders

* wooden and silver walls now regained their transparency

* accidental note leftover

* NOW silver walls are no longer transparent

* the clockcult, bloodcult girder have been unsmoothed for now

and unwrenched girders have been permanenetly unsmoothed

* New Rwall Icons

---------

Co-authored-by: PigeonVerde322 <[email protected]>
mystery3525 pushed a commit to mystery3525/BeeStation-Hornet that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Feature Fix Golden ⭐ For high-effort PRs that make big and good improvements to the game. Sprites Test Merged This PR is currently in rotation
Projects
None yet
Development

Successfully merging this pull request may close these issues.