[Port] Radiation Rework #11434
[Port] Radiation Rework #11434
Conversation
|
Well, at least its now possible to integrate actual radiation shielding into modsuits |
github-actions
bot
added
the
TGUI-Changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Isn't that how radiation works? It is known as the silent death. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Supermatter Power Output
The power output from the SM is ridiculous, and the radiation it makes is huge.
With a roundstart N2 setup:
And radiation filled the entire room until this point
At the very least, the power output shouldn't be intended since the SM currently makes in the range of 100-300kW
Radiation Effects
I dislike how clearing radiation works. Here is my feedback:
- Make radiation like the bleeding status effect, where it has an amount attached to it (give it a limit)
- Tick the counter up as you increase radiation instead of using a prob() that randomly gives the effect
- If the effect is less than a threshold, don't throw the alert and do nothing (at this point it should slowly decrease over time until it goes away)
- One you are at a certain amount, then start doing the toxin damage
- Showering lowers that value, all the rad-meds lower the value of radiation. (Maybe either no toxin damage should increase the rate at which rads go away, or washing/changing clothes should somehow have an effect, but the clothes one is harder and may be out of reasonable scope).
- Remove the halting of the effect entirely
- If you get a lot of rads and start approaching the limit, then start doing some of the other radiation fluff like nosebleeds and hair clumps falling out (these don't have to actually do anything, but are there for flavour)
| if (human_parent.stat > DEAD) | ||
| human_parent.dna?.species?.handle_radiation(human_parent, world.time - beginning_of_irradiation, delta_time) |
There was a problem hiding this comment.
Having a stat greater than dead is impossible
| //If the species gains good things from radiation. See: Dionae | ||
| #define TRAIT_RADBOOSTER "rad_booster" |
There was a problem hiding this comment.
The name of this trait doesn't really make much sense. I also think that theres a bit of an issue where if you have a species that heals from rads and forget to put the trait that stops you from getting the irradiated component then your species will get permanent immunity which is a bit of a trap for future coders but I guess its fine
There was a problem hiding this comment.
I see what the intention is for this now, TRAIT_ALWAYS_PROCESS_RADS, TRAIT_BENEFICIAL_RADS or something might make more sense
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Making this a draft once more, will need to work on this a lot after LINDA is done. |
|
This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed. |
|
was told to close this until i decide to work on it once more |
|
Took away the stale label so you should be able to freely re-open it without issues when you do get to it |
About The Pull Request
Ports TG Station's:
Why It's Good For The Game
Currently radiation has no proper warnings when you're irradiated, not to mention it takes way too long to get rid of it if you are contaminated. This should fix a few things, while keeping things, hopefully, sane.
Testing Photographs and Procedure
Screenshots&Videos
Supermatter:
2024-09-13.19-57-50.mp4
Supermatter in proper working condition:
2024-09-13.21-51-22.mp4
Radiation status effect:
2024-09-13.20-00-26.mp4
Changelog
🆑 Mothblocks, ShizCalev, KittyNoodle, Krysonism, castawaynont, GuillaumePrata, Tiresoup, blessedmulligan, Pickle-Coding, LemonInTheDark, Ghilker, esainane, yoyobatty, vincentiusvin, XeonMations
balance: Radiation is now a status effect, where you are either irradiated or not. When irradiated, you will take constant toxin damage, and irregular burn damage. Radiation is removed once all toxin damage is healed. Standing under a shower will pause the harmful effects of radiation, making it easier to heal. Everything that is irradiated will glow green.
del: Pluoxium can no longer be created by irradiating oxygen and carbon dioxide
del: Removes contamination from radiation.
balance: Uranium structures will irradiate those around them, but will be delayed, giving you time to stay away.
del: The radioactive microlaser no longer irradiates, but still has its knockdown, which was never related.
balance: Screwdriver (the drink) and Potassium Iodide are similar. They will heal toxin damage when the target is irradiated.
balance: Screwdriver, Potassium Iodide, and Pentetic Acid will halt the damaging effects of radiation, just like showers. This means no tox damage or burns.
balance: The gravity generator, instead of giving radiation when on, will now have a high gravity field around it.
balance: Radiation protection has been kept to engineering hardsuits, rad suits.
balance: Genetics no longer uses radiation, but instead genetic damage. Genetic damage works very similarly--once it tops 100%, you will start to take toxin damage. Gorillas are now made through genetic damage instead of radiation.
del: Removed the halogen counter PDA app.
del: Removed the emag effect on geiger counters, though an emag functionality can be added back later.
del: Removed the geiger counter from cyborgs, but mostly because it's not actually really that useful anymore? Everything glows green!
del: Removed the advanced wirebrush, a weird consumer of radiation with an extremely niche purpose. The standard wirebrush still exists.
del: Removed radiation scanning from meson goggles.
del: Removed leftover radiation collectors on ruins.
del: Removed radiation from the radioisotope thermoelectric generator, though it still produces power. Trivia points if you actually know what that is!
balance: The EMP'd advanced energy gun now deals burn damage instead of radiation damage.
balance: Unstable Mutagen now deal toxin damage instead of radiation damage.
balance: Breathing tritium will now irradiate you after a certain amount, as well as deal toxin damage.
del: Removed radiation collectors
fix: Cyborgs and those with rad immunity will no longer get the radiation burn message when near something being dusted by the supermatter.
spellcheck: Rewrote some messages when near something that was dusted by the SM
balance: The further you are from a radiation pulse, and the more objects that block it, the lower your odds are to get irradiated.
balance: Most radiating emitting things have their radiation pulses functionality changed. Being near them is more dangerous, and being far away is less dangerous.
fix: Radiation pulses will ask MC if they should continue processing for every turf they iterate through, rather than just every pulse.
change: The supermatter's power is now harvested in the form of tesla coils.
del: Made the black hole unable to be obtained without adminbus.
qol: supermatter zaps now change color based on the power generated, starting from red and going toward blue the higher the power emitted
/:cl: