Fixes atmos processing race condition #11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossedfall
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Atmos demands that a machine starts processing on /New(), however this can cause it to start processing prior to its atmos being initialised. If a template is loaded post-roundstart then this has the potential to cause runtimes, which was the case for shuttles being loaded in the unit tests.
Why It's Good For The Game
This should correct unit tests and fix some erronous behaviours.
Testing Photographs and Procedure
Check to make sure atmos machines are still functioning as intended when mapped:
Check to make sure atmos machines are still functioning as intended when on shuttles:
Check to make sure atmos machines are still functioning as intended when constructed:
Changelog
🆑
fix: Fixes race condition in atmos processing which results in unit tests failing due to shuttles loading post-roundstart.
/:cl: