Fixes a critical mistake in shuttles.dm #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This introduces a hotfix for shuttles.dm, allowing map generators to start running before other systems start running.
Currently, shuttles doesn't init until all shuttles have been placed but the map generators don't run until shuttles have finished init, causing it to block for 30 seconds.
This PR serves as a hotfix to quickly fix the issue, but there is still time wasted during init unnecessarilly and a proper fix which involves a much more in-depth rework of initialisation in the MC will come later. (We need to be able to wait for asynchronous tasks that are raised during initialisation)
Why It's Good For The Game
Shuttles will no longer take 30 seconds to load, and #11448 will be resolved.
Fixes #11448
Testing Photographs and Procedure
Changelog
🆑
fix: Fixes shuttle loading taking 30 seconds.
/:cl: