Fixes invalid cache in maploader #11450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Always an issue, but much more likely now. Speed merging. |
ss13-beebot
added a commit
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes an issue with the asynchronous map loader, where a cache could be used while out of date.
This occurred because the cache would be immediately set, so if something started loading before the cache was fully completed, then it would be unable to find certain parts of that cahce.
Why It's Good For The Game
This could result in certain templates failing to load.
Testing Photographs and Procedure
Changelog
🆑
fix: Fixes a maploading race condition that would result in invalid caches being used while loading maps.
/:cl: