Despaces the Prison on Fland #11472
Merged
Despaces the Prison on Fland #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Could you add a test in tools\maplint\lints
It needs to read
/turf/open/space:
banned_neighbors:
- /obj/machinery/door
- /obj/effect/spawner/structure/window
and then we can expand on it in the future.
You can put an = before the typepath if you don't want to match subtypes
|
Wouldn't banning space next to windows cause a ton of issues? |
It wasn't for banning windows next to space, it was banning window tiles and doors on space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a hole in fland introduced by #11364
Also adds a new linter check that checks for space underneath windows and doors.
Why It's Good For The Game
Space, the final frontier. I don't think anyone can breathe it though. so I think it might be safer to seal it off.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
code: Introduces a new mapping linter check for windows and doors on space
fix: [FlandStation] The prison is no longer exposed to space roundstart.
/:cl: