Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUD icons sorted into it's own folder #11517

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

PestoVerde322
Copy link
Contributor

About The Pull Request

This massive PR moves almost all the HUD elements into it's own dedicated folder, that's all.

Why It's Good For The Game

QOL for developers and contributors.

Testing Photographs and Procedure

Screenshots&Videos

immagine

Changelog

🆑
refactor: Moved (almost) all the HUD elements into it's own folder.
/:cl:

PigeonVerde322 added 3 commits September 18, 2024 13:34
@PestoVerde322
Copy link
Contributor Author

I STRONGLY suggest a TM, just in case something breaks here.

@EvilDragonfiend
Copy link
Member

This is good to go with

highly recommended because my PR can catch misplaced cases.

@PowerfulBacon
Copy link
Member

It doesn't seem to add any more testing or lints

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, we really ought to lint against mutable appearance, image and icon being used with invalid icon states

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 20, 2024
@PowerfulBacon
Copy link
Member

I STRONGLY suggest a TM, just in case something breaks here.

If a PR like this needs testmerging then you haven't tested it locally well enough

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Sep 20, 2024

(I deleted my comment. nvm about it. I was sleepy atm lol)

Merged via the queue into BeeStation:master with commit 2b22806 Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants