Ports the removal of proc_holders from tg after 2 years of it not being done #11527
Conversation
Second commit will remove all the errors In the meantime pretty please tell me if you people want anything else to go with this pr
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
Administration
Tools
TGUI-Changes
I am still working on this
new paradigm, closing the gates of hell
time to port clockcult from yoggers
|
Might be worth looking at #11628 which wraps cooldown action into the base of action, and merges the cooldown timers of all 3 together. This could make porting easier since it alleviates the pain caused by faffing around with bee cooldowns fighting with TG cooldowns. |
|
Oh actually just get this done and I'll update that later. As long as this keeps the button click feedback and cooldown icon, I can modify it later. |
Now only thing left is bug fixing and merge conflict Current bugs to fix Clockwork slab empowerment (spells like kindle etc) Icons not being correct
why are you guys so fast
|
There might be many bugs etc as this is far too big for me to catch |
What the fuck is a proc helper reference!!!!
Only thing left is to clean up maps
|
somethin about this is preventing me from using necro chaplain's bind soul...no moar holy skeleton :(
|
|
Can confirm from VV inround that there was nothing apparent that should be blocking the player from using the spell. The button was just not usable and gave no error message. |
You have a null rod chainsaw arm, which I believe prevents the use of magic. I'll verify and add a message in chat |
|
I have tested it and an appropriate error message is presented in chat. I've fixed a bug with the background not appearing correctly. |
|
Oh, this PR actually introduced the flag meaning the spell required no anti magic. I'll remove that. |
|
Apparently has a bug with xenoarch icons. Will merge once thats looked into, but I'm coming off for now. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
(mainly)Ports:
proc_holdersfrom existence. Refactors all wizard, xeno, spider, and genetics powers to be actions. Also refactors and sorts ton of accompanying code. tgstation/tgstation#67083From testmerge:
Also:
Mousepointer fix copy pasted from
This is now a ports proc_holder removal, action button refactor and antimagic refactor
Why It's Good For The Game
Mostly for the refactor of spell code making it easier and possible to make crazy spells and also to make this codebase more closer to modernity
Also this doesn't affect the players
Testing Photographs and Procedure
Once this actually works I will put some screenshots here. Until then please direct my attention towards bits and bops of code that I might've borked up while porting this. Until then this will be a draft.
There is still a ton of work before this can even be considered for merging
Random ass actions (red ones are unavailable because i got no wizard robe)
Action palette thing (very cool)
Cooldown test
Action palette test
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: Removes proc_holders in favour of using /datum/action and expanding on it some more
refactor: refactors how spell code works making it badass and stuff
tweak: Many spells changed to conform with the new code order, included is telepathy that now works by providing the user with a list of targets instead of clicking on one
tweak: Spell cooldowns are very likely to be slightly different (Actually readable) Old cooldown code is an unreadable mess
/:cl: