Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes not all escape pods arriving to escape pod shuttle at round end #11566

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

aramix273
Copy link
Contributor

About The Pull Request

a new escape pod shuttle was introduced with #11150, however the ids of the escape pod docks in it were not tweaked to match those of their respective escape pods (had pod_2_away instead of pod2_away for example); this PR changes just that

this caused multiple identical runtimes (Runtime in docking.dm,4: Cannot read null.docked) because new_dock argument would be null (from SSshuttle.getDock("pod2_away") which could not find said dock and returned null), and these should now be solved

Why It's Good For The Game

allows more than one escape pod to make it to escape pod shuttle (and probably counts towards escape objective)
fixes #11374

Testing Photographs and Procedure

Screenshots&Videos

tested on Meta Station with 3 escape pods
image

Changelog

🆑 Aramix
fix: all escape pods should now properly arrive to the escape pod shuttle at end of round
/:cl:

@github-actions github-actions bot added the Mapping DMM Change label Sep 25, 2024
@Tsar-Salat
Copy link
Contributor

I am such a observant mapeditor 🍹 :>

@Rukofamicom Rukofamicom added this pull request to the merge queue Sep 28, 2024
Merged via the queue into BeeStation:master with commit c717f48 Sep 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Mapping DMM Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pods never arrive at new espace pod shuttle.
3 participants