-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1728 Pirate Shuttle #11596
1728 Pirate Shuttle #11596
Conversation
The black powder barrel isn't exploding and causes runtime errors. |
golden age of piracy was 1650 and 1720 so you were 8 years too late |
No. |
This should not be possible to detonate on its own or it absolutely will be the majority of the time most likely. I like the flavor but I am really not sure how to justify making it unable to detonate on its own. |
I did give them a few 30u bottles of black powder, but that can only make a few improvised shots or maybe one grenade, which won't be able to blow up a door. It is quite counterintuitive, but should I make the barrel simply not do anything and just vanish? |
Fuck. Thank you. |
Oops, I meant to write the ammo it uses waa nerfed from 55 to 25. Not the gun itself. Should I still make a subtype of it with lower damage? Do we still use a gun anywhere in the code with 55 damage per shot? |
The whole point of revolvers is to be a high damage, but highly expensive weapon. The detective's revolver goes against this by having easilly printable ammo and lower damage though, so that one kind of breaks the rules. The traitor revolver actually does 60 damage. |
Just my 2 cents, but would something along the general lines of a chem dispenser work? Barrel looking object with a finite amount of black powder to dispense without actually being something you can detonate in and of itself. It is admittedly a bit of a special snowflake solution (and probably outside the PR scope). |
Or just limit the size of the explosion of the barrel so its more efficient to make grenades |
I also like this option, even if it's a bit snowflakey, this is the kind of case where that's more or less justified. |
I highly suggest taking a look at the cannons/cannonballs/gunpowder barrels from TG, they perfectly fit what you want to accomplish and allows them to go straight to action, pirates taking time to make nades seems like it will deny a lot of surprise attacks, not to mention not everybody knows how to make nades |
While making your own weapons sounds fun, pirates are midround spawns, and as such lack the prep time required. additionally, having to spend 20-45 minutes (depending on how skilled the players are) to even have a fighting chance might not be the best idea. Perhaps have sufficient spawning supplies to 1) demonstrate you are meant to make/use ghetto ammo and explosives and 2) to decrease prep time required. |
You still get enough ammo to take down one or two armored opponents assuming you hit enough shots. There are six weapons in total. With a free rubber buckshots box and five free improvised buckshot shells. I would hope to make this maybe an early round or actual mid-round role rather than late game (which is when pirates tend to spawn most often), but that's outside the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't fixed the runtime issue with the black powder barrel and it currently does not explode at all when destroyed. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the nerf to the nagant revolver. Choose a more reasonable value than 25 since that's very little damage for a ballistic weapon and a revolver weapon. If you want a revolver weapon, it should be high damage but have limited ammo.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Due to personal circumstances, author has requested that all PRs be treated "as-is" for the time being. |
About The Pull Request
Finally adds the 1728 pirate shuttle. Offers a different way to play pirates.
They are given a 1000 unit barrel filled to the brim with black powder. This is intended to be used for makeshift grenades but could also be used to take out a large chunk of the station. I am not sure if this is a good thing or not, please discuss it.
Why It's Good For The Game
I think it is an overall nerf on the pirates, it has a 50/50 chance of spawning instead of the default ship and requires the pirates to play it differently. Instead of being given top of the line gear, they are given shit. Even have to make their own ammo and explosives!
Testing Photographs and Procedure
Screenshots&Videos
2024-09-28.12-59-24.mp4
If the pirates are not careful, their entire shuttle might explodey.
Changelog
🆑
add: Added 1728 pirate shuttle!
balance: Nerf/buffs pirates and their shuttle.
add: Black powder barrel.
balance: Nerf the Nagant Revolver from 55 damage to 25.
/:cl: