Moves job-based drink affinities to liver traits

[Tsar-Salat]

About The Pull Request

Moved job-based drink affinities to livers.

To be able to tell what affinity trait a liver has, one needs a medhud equipped then examine the liver.

Ports:

• Rework job food/alchohol benefits into livers  tgstation/tgstation#55721
• Merges donut lover into law enforcement metabolism tgstation/tgstation#70921

Why It's Good For The Game

Hardcoding is bad coding practice. Being able to just add a trait and have something work is leagues better than having some stupid check on the mind for a specific string.

Testing Photographs and Procedure

Screenshots&Videos

I gibbed a Secoff

Changelog

🆑 rkz, coiax, JohnFulpWillard
tweak: Moved job-based drink affinities to livers. Medhuds can tell what trait a liver has. This trait affects how it reacts to job drinks like Screwdriver(Engi), Triple Sec(Security), etcetera.
add: clownops are naive, like regular clowns. They can't tell if people dead or sleeping.
add: makes bananium golems clumsy
add: Clown livers honk
fix: naive trait checks now check mind, instead of mob
/:cl:

[EvilDragonfiend]

🔑

The traits are dedicated for job feature, but this moves that to 'liver features'. The PR claims making it less hardcoding, but I see it's way more hardcoding.
Having more traits to job mind makes sense, but putting such traits into liver doesn't make sense when traits are given by a job spawning.
But also, just replacing your liver loses a trait inside, and there's no way to gain such trait. Of course, it also means you can get a trait of another job when you take someone else's liver, but I don't think that's what it is supposed to be.

I will lift my key when traits are given as a mind trait. This shouldn't be liver trait.

[Tsar-Salat]

The PR claims making it less hardcoding, but I see it's way more hardcoding

Turning something from a string check to a trait check is objectively a dehardcode. It doesn't really matter how one sees it. Calling it more of a hardcode makes zero sense.

Before this pr, the check was based on a unchangeable var, after this pr it is possible to affect it outside of VV menu. That is not hardcoding.

Having more traits to job mind makes sense, but putting such traits into liver doesn't make sense when traits are given by a job spawning.

"This pr doesn't make sense because it isn't the way it currently works" Yeah... Thats the point. I think attaching this stuff to a roundstart string is bad code design. It should be based on something tangible.

But also, just replacing your liver loses a trait inside, and there's no way to gain such trait. Of course, it also means you can get a trait of another job when you take someone else's liver, but I don't think that's what it is supposed to be.

A paragraph to say basically that you want the status quo. Your argument wasn't really convincing so I dont really see anything to do here.

[PowerfulBacon]

Failing checks

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed.