Fixes some do_after bugs sourced from mobility #11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsar-Salat
changed the title
Rukofamicom
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR should fix remaining issues resulting from bad mobility checks or not being checked at all.
Stasis beds will now be escapable when bucklecuffed to them, like any other bed.
Chair bucklecuff unbuckle do_after should now progress properly to its conclusion everytime, and be interrupted correctly.
A player gave an example of discovery scanners being broken, so that has been dealt with as well. Its now possible to scan multiple mobs at the same time again.
closes #11223
closes #11599
Ports:
Why It's Good For The Game
Theres been a few issues.
Chief among these were being buckled to stasis beds not being escapable because both the handcuffs & stasis locked down the traits that let you deal with the other status effect, respectively. Additionally, I was told people were having trouble escaping bucklecuffs from chairs with the do_after doing nothing.
This should fix all the stuff people reported to me. Though, I'm sure someone somewhere didn't say anything though and we'll just find out in 2 months.
Testing Photographs and Procedure
Screenshots&Videos
Stasis bucklecuff
dreamseeker_kL6RaYX2eD.mp4
chair bucklecuff
dreamseeker_VVJ0eeiPVs.mp4
Discovery scanner
dreamseeker_Lo0B1uHMFR.mp4
Changelog
🆑 rkv, LemonInTheDark, kriskog
fix: fix stasis bed bucklecuff escaping
fix: fix chair bucklecuff escaping
code: potentially addresses some hardeletes in progressbar code
code: stoplag no longer stops lag in unit tests (it can hardelete)
code: Refactored the incapacitated proc to skip optional arguments and use the named arguments properly to improve readability.
/:cl: