Fixes interaction of Camera Console and Buttons #11671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
With #11306, I made a change that meant that /atom/proc/interact() returns TRUE always when you have the atom_interaction_flag
INTERACT_ATOM_UI_INTERACT
. That flag is on these atoms, which useattack_hand()
to handle all their code. Ideally we would enforce this change and refactor all the instances ofattack_hand()
to useinteract()
instead, but I don't feel like bug hunting for the next several months.Why It's Good For The Game
ough
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Camera Console works
![image](https://private-user-images.githubusercontent.com/30960302/375880108-848949fe-05ba-45f2-8f48-2fad55e18254.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzc1ODAsIm5iZiI6MTczOTI3NzI4MCwicGF0aCI6Ii8zMDk2MDMwMi8zNzU4ODAxMDgtODQ4OTQ5ZmUtMDViYS00NWYyLThmNDgtMmZhZDU1ZTE4MjU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEyMzQ0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2YzliMzI0ODBmZjg1NDQ4OGU5ZjNlZDk2M2U5ZjhhMDE0YmM0MzM5OWM3NzFiNTY2Nzc4ZmM4OWVmZjg5MmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.U8VdE3KNK5LZiY-e_f90dorZAU4TOQFQDPn88BuQ9pE)
Buttons Work
![image](https://private-user-images.githubusercontent.com/30960302/375880569-c261d519-cd6e-4120-ae64-55b6be00fc6d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzc1ODAsIm5iZiI6MTczOTI3NzI4MCwicGF0aCI6Ii8zMDk2MDMwMi8zNzU4ODA1NjktYzI2MWQ1MTktY2Q2ZS00MTIwLWFlNjQtNTViNmJlMDBmYzZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEyMzQ0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0YjE1MGVkNTg2ZTc5N2NjZjkyYmFiNmQ4YTM3ZjE3OGZmZjlkZWQ2YWQ4ZDBjMWEyMzRlNmZlMTA3YWNmNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xE_6zIWOP9c-9-legIFku9KgxYTr8sCjNa7b9rAAmk8)
Rechargers still work.
![image](https://private-user-images.githubusercontent.com/30960302/375885603-57b60666-e3e0-4e73-96b2-3e3a3a7b76f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzc1ODAsIm5iZiI6MTczOTI3NzI4MCwicGF0aCI6Ii8zMDk2MDMwMi8zNzU4ODU2MDMtNTdiNjA2NjYtZTNlMC00ZTczLTk2YjItM2UzYTNhN2I3NmYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEyMzQ0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxNTk1NDhmOWE4ZTAwNDVkM2E4NTkxZDAwYWM2ZjQwYzUyZTFjZTY5NTA5YzVmNGEzOGJiMjJjODcwMTU3OWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zJ1ytPBeN2DhyJvnl1hA5B1jrnp7ve8XQbIBpZvdDEY)
Changelog
🆑
fix: Interaction with cameras and buttons not working.
/:cl: