Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes interaction of Camera Console and Buttons #11671

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mystery3525
Copy link
Contributor

@mystery3525 mystery3525 commented Oct 11, 2024

About The Pull Request

With #11306, I made a change that meant that /atom/proc/interact() returns TRUE always when you have the atom_interaction_flag INTERACT_ATOM_UI_INTERACT. That flag is on these atoms, which use attack_hand() to handle all their code. Ideally we would enforce this change and refactor all the instances of attack_hand() to use interact() instead, but I don't feel like bug hunting for the next several months.

Why It's Good For The Game

ough

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Camera Console works
image

Buttons Work
image

Rechargers still work.
image

Changelog

🆑
fix: Interaction with cameras and buttons not working.
/:cl:

@MarkusLarsson421
Copy link
Contributor

Do weapon and cell rechargers also work?

@mystery3525
Copy link
Contributor Author

Rechargers still work
image

@Rukofamicom Rukofamicom enabled auto-merge October 11, 2024 21:14
@Rukofamicom
Copy link
Contributor

Game breaking bug

@Rukofamicom Rukofamicom added this pull request to the merge queue Oct 11, 2024
Merged via the queue into BeeStation:master with commit 1f3bf82 Oct 11, 2024
21 checks passed
@mystery3525 mystery3525 deleted the fix-interaction branch October 12, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants