Ports refactor/organization of mob spawners, new ashwalker egg sprite #12042
+2,187
−1,808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfbdc28.
github-actions
bot
added
Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
We now organize mob spawners based on type, and into separate files.
previously it was:
/obj/effect/mob_spawn&/obj/effect/mob_spawn/corpsenow it is:
/obj/effect/mob_spawn,/obj/effect/mob_spawn/ghost_role&
/obj/effect/mob_spawn/corpse,/obj/effect/mob_spawn/corpse/human,/obj/effect/mob_spawn/corpse/human/damagedAdditionally, I ported TG's ashwalker egg sprite, because its ugliness was striking to me.
Ports:
Why It's Good For The Game
The code is now readable and not all stacked into two files and various "fluff" files.
Should be easier to both maintain and add more roles in the future,
Testing Photographs and Procedure
Screenshots&Videos
Ashwalker
dreamseeker_b5QVRjnuHD.mp4
Changelog
🆑 rkz, fikou, armhulen, jlsnow301, san7890
refactor: reorganizes & refactors mob spawner code to be subtyped
code: moved messenger check to the app instead of on the pda itself
add: adds new sprite for ashwalker eggs
add: ashwalker eggs are now structures that contain the mob spawner itself
add: better TGUI spawner menu (contains flavortext and colored text)
code: adds mob spawner unit test
/:cl: