Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New silicon emote, slowclap + emotes for MMIs #12043

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrmanlikesbt
Copy link

@mrmanlikesbt mrmanlikesbt commented Dec 16, 2024

About The Pull Request

Adds a new slowclap emote for silicons.
MMIs can use silicon emotes now

Why It's Good For The Game

Arguably the greatest emote to have ever existed in SS13. Perfect for mocking assistants when they shock themselves

Testing Photographs and Procedure

Screenshots&Videos
2024-12-16.04-00-45.mp4

Changelog

🆑
add: Silicons have a new emote, slowclap
tweak: MMIs can use silicon emotes
/:cl:

@mrmanlikesbt mrmanlikesbt changed the title initial New silicon emote, slowclap Dec 16, 2024
@Therealdoooc213
Copy link
Contributor

Get this guy a good pr label rn

@RDS88-beeman
Copy link
Contributor

can MMIs, carded AIs, and posibrains also get the emote? So we can make the obvious joke when the AI gets put into a intelitater

@Liver-1
Copy link
Contributor

Liver-1 commented Dec 16, 2024

The best PR. Maybe ever?

@Therealdoooc213
Copy link
Contributor

Oh yeah, IPC's should also probably get this emote.

@XeonMations
Copy link
Contributor

Why only for silicons?

@mrmanlikesbt
Copy link
Author

IPCs can slowclap now. Went ahead and made it so MMIs can use all silicon emotes too
https://github.com/user-attachments/assets/d87d60be-8ef7-492e-a457-9b03040f50eb

@mrmanlikesbt mrmanlikesbt changed the title New silicon emote, slowclap New silicon emote, slowclap + emotes for MMIs Dec 16, 2024
Copy link
Contributor

@ClownMoff ClownMoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird way to word it. Why would borgs have a slow clap processor? Why would a MMI have a slow clap processor? Maybe a synthetizer. But then again, kinda silly emote worded this way. Ideally emotes should be able to be understanded without sound, and the way its currently worded is a little confusing. Also, in my opinion something like "plays a slow clapping sound" is a much more dry and sarcastic statement.

/datum/emote/living/carbon/human/robot_tongue/slowclap
key = "slowclap"
key_third_person = "activates their slow clap processor."
message = "activates their slow clap processor."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message = "activates their slow clap processor."
key_third_person = "plays a slow clapping sound."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ClownMoff ClownMoff Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated my original review with a more extensive opinion while you were responding if you want to read it. I did not remember that Portal phrase, but even though its a funny nod to a beloved franchise I still think it does not translate well into the game worded this way

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can agree about why a borg would have a slow clap processor in the first place, but if you used that logic elsewhere half the game would be removed + this isn't a HRP server. As for the wording of the emote, I disagree. I think how it is now is funnier and the only problem I see with it because of it's length it doesn't fully display in runechat (you can see this in the testing evidence). Thanks for the feedback though!

@Sadboysuss
Copy link

mfw there is no attribution to the source of the sound file

@mrmanlikesbt
Copy link
Author

already in the game files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants