-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New silicon emote, slowclap + emotes for MMIs #12043
base: master
Are you sure you want to change the base?
Conversation
Get this guy a good pr label rn |
can MMIs, carded AIs, and posibrains also get the emote? So we can make the obvious joke when the AI gets put into a intelitater |
The best PR. Maybe ever? |
Oh yeah, IPC's should also probably get this emote. |
Why only for silicons? |
IPCs can slowclap now. Went ahead and made it so MMIs can use all silicon emotes too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird way to word it. Why would borgs have a slow clap processor? Why would a MMI have a slow clap processor? Maybe a synthetizer. But then again, kinda silly emote worded this way. Ideally emotes should be able to be understanded without sound, and the way its currently worded is a little confusing. Also, in my opinion something like "plays a slow clapping sound" is a much more dry and sarcastic statement.
/datum/emote/living/carbon/human/robot_tongue/slowclap | ||
key = "slowclap" | ||
key_third_person = "activates their slow clap processor." | ||
message = "activates their slow clap processor." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message = "activates their slow clap processor." | |
key_third_person = "plays a slow clapping sound." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated my original review with a more extensive opinion while you were responding if you want to read it. I did not remember that Portal phrase, but even though its a funny nod to a beloved franchise I still think it does not translate well into the game worded this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can agree about why a borg would have a slow clap processor in the first place, but if you used that logic elsewhere half the game would be removed + this isn't a HRP server. As for the wording of the emote, I disagree. I think how it is now is funnier and the only problem I see with it because of it's length it doesn't fully display in runechat (you can see this in the testing evidence). Thanks for the feedback though!
mfw there is no attribution to the source of the sound file |
already in the game files |
About The Pull Request
Adds a new slowclap emote for silicons.
MMIs can use silicon emotes now
Why It's Good For The Game
Arguably the greatest emote to have ever existed in SS13. Perfect for mocking assistants when they shock themselves
Testing Photographs and Procedure
Screenshots&Videos
2024-12-16.04-00-45.mp4
Changelog
🆑
add: Silicons have a new emote, slowclap
tweak: MMIs can use silicon emotes
/:cl: